True OrElse getting rendered as just '1' about expressionextensionsql HOT 6 CLOSED

Fixed and new package released. Please check.

from expressionextensionsql.

Thanks for the contribution. I'm studying the modifications. Once you get a final solution a new version will be generated.

from expressionextensionsql.

I should have mentioned, I get this error with the ExpressionExtensionSQL.Dapper package so it seems to be something with how it is translating the boolean to a bit 1 or 0 for the SQL expression

from expressionextensionsql.

Thiago,

I was able to fix this by making the following change to the Concat method:

public static WherePart Concat(WherePart left, string @operator, WherePart right) {
            if (right.Sql.Equals("NULL", StringComparison.InvariantCultureIgnoreCase)) {
                @operator = @operator == "=" ? "IS" : "IS NOT";
            }
            if(left.Sql == "1") {
                left.Sql = "(1=1)";
            }
            if (left.Sql == "0") {
                left.Sql = "(0=0)";
            }
            var w = new WherePart() {
                Parameters = left.Parameters.Union(right.Parameters).ToDictionary(kvp => kvp.Key, kvp => kvp.Value),
                Sql = $"({left.Sql} {@operator} {right.Sql})"
            };
            return w;
        }

I don't think that's a very good solution but your code is very efficient, nested and recursive so I was not able to figure out the best spot to implement a fix.

But the issue arises where the left part of the expression starts with "True AndAlso ..." so just a boolean (i.e. 'True') with no property tied to it (i.e. TableName.PropertyName = True) is what gets interpreted so it just extracts a 1 or a 0

from expressionextensionsql.

Good Morning. I will do the correction today and upload a new version in nuget

from expressionextensionsql.

That seems to work for me, I'll continue testing it this week, thank you

from expressionextensionsql.