Use numbers instead of strings to represent log levels about roarr HOT 3 CLOSED

I don't mean to sound petty or the early-optimizer type, but I'm not sure about the implications of having an extra property.

I believe that a property with "error" as its value doesn't add much information to a computer-friendly format like JSON. This is meant for humans.

Adding ,"logLevelWeight":50 to every log entry adds 21 bytes of redundant information.

Just trying to make some back-of-the-envelope math here. Imagine a mid-sized application that deals with 50,000 requests per day. Imagine also that each request creates 10 log entries, so we are talking about 500,000 log entries per day.

Those extra 21 bytes represent:

• 10,5 GB in 1 day
• 315 GB in 1 month
• 3,78 TB in 1 year

For larger applications, this might become out of hand. (One might argue that larger applications should do some kind of sampling on their logs, but I fundamentally disagree with this).

So I believe that the only information needed in the JSON generated by Roarr should be the logLevel as an integer. Then tools for humans like pretty-print, majorly used during development, should be responsible for translating 50 into ERROR.

from roarr.

Done

from roarr.

Absolutely. It can be added as an additional property, e.g. logLevelWeight. Unless you have suggestion for a better name?

from roarr.