Code Monkey home page Code Monkey logo

Comments (3)

jedwards1211 avatar jedwards1211 commented on July 25, 2024

Let me rewrite the above using your terminology. It would not be a huge leap to go from this code to a canonical reducer composition that uses .withMutations.

This function can easily be used to efficiently combine action map reducers as well; if what you pass to combineImmutableReducers is (abstractly speaking) a multi-level map of domain -> action name -> action handler, you just invert that into action name -> domain -> action handler and do reducerMap(mapValues(multiLevelMap, combineImmutableReducers)). In real code (leaving out my implementation of reducerMap and composeReducers):

import {reduce, forEach, mapValues, keys, identity} from 'lodash';
import reducerMap from './reducerMap';
import composeReducers from './composeReducers';

function combineImmutableReducersBase(reducers) {
  if (!keys(reducers).length) return identity;
  return (state, action) => state.withMutations(mutableState => reduce(
    reducers,
    (nextState, domainHandler, domain) => nextState.update(domain, value => domainHandler(value, action)),
    mutableState));
}

export default function combineImmutableReducers(reducers) {
  let actionMap = {};
  let otherReducers = {};
  forEach(reducers, (domainHandler, domain) => {
    if (domainHandler.actionMap) {
      // invert from domain -> action name -> action handler 
      //          to action name -> domain -> action handler
      forEach(domainHandler.actionMap, (actionHandler, actionName) => {
        (actionMap[actionName] || (actionMap[actionName] = {}))[domain] = actionHandler;
      });
    }
    else {
      otherReducers[domain] = domainHandler;
    }
  });

  return composeReducers(
    reducerMap(mapValues(actionMap, combineImmutableReducersBase)),
    combineImmutableReducersBase(otherReducers)
  );
}

from redux-immutable.

gajus avatar gajus commented on July 25, 2024

Not relevant in [email protected].

from redux-immutable.

jedwards1211 avatar jedwards1211 commented on July 25, 2024

@gajus nice to see you finally took my suggestion ;)

from redux-immutable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.