Code Monkey home page Code Monkey logo

Comments (5)

j-f1 avatar j-f1 commented on June 17, 2024

Put the switch on the next line next to a label?

from overreacted.io.

gaearon avatar gaearon commented on June 17, 2024

I don't want to change anything visually — just to get rid of the hack

from overreacted.io.

gariasf avatar gariasf commented on June 17, 2024

The problem I see here is the fuckery going on with margins and heights on the header element combined with its container. It's bloated with whats seems to be everything.

I also think that fixing this is going to inevitably imply changes in the spacing, meaning the vertical separation might change a few pixels. (Unless we get pixel perfect and start using weird seemingly random values, which I'm not a fan of.)

I'll try to come up with a PR tomorrow to see if what I think is correct or to prove that I'm a complete idiot for thinking I can fix this.

from overreacted.io.

gaearon avatar gaearon commented on June 17, 2024

I just care that

  • switcher is aligned with the bottom of the header
  • switcher retains position while navigating between home page and blog post

I don't mind weird values as long as I don't have to tune two weird values against each other (like I have to now).

from overreacted.io.

gariasf avatar gariasf commented on June 17, 2024

There, that commit should do the trick.
Please let me know if there's anything you'd like to change.

from overreacted.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.