HS105 Testing about pyhs100 HOT 4 CLOSED

The issue with location has been fixed in git, but there has been no releases sofar. If you want, you can install the newest git with pip to see if it helps. There is no reason why controlling should not work on devices in other networks, discovery on the other hand is broadcast-based and will not be available there.

from pyhs100.

I don't know how to get the latest version from git, but I did find the relevant change needed in pyHS100.py and changed it. That did correct the issue in status.

• Maybe add some self check by looking for local subnet and exit cleanly if IP used is not subnet and therefore broadcast would not work. Just an idea.

    info = self.sys_info
    loc = {"latitude": None,
           "longitude": None}
  
    if "latitude" in info and "longitude" in info:
        loc["latitude"] = info["latitude"]
        loc["longitude"] = info["longitude"]
    elif "latitude_i" in info and "longitude_i" in info:
        loc["latitude"] = info["latitude_i"]
        loc["longitude"] = info["longitude_i"]
    else:
        _LOGGER.warning("Unsupported device location.")
  
    return loc
  

from pyhs100.

For discovery one should not define an IP at all, so I think having a check for broadcasting would be superfluous. Here's the documentation on how to use pip with version control systems: https://pip.pypa.io/en/stable/reference/pip_install/#vcs-support . The piece of code you found is indeed correct, are you having any other issues with your HS105 now?

from pyhs100.

I think this can be closed, please reopen / create a new issue if needed.

from pyhs100.