Comments (4)
The issue with location has been fixed in git, but there has been no releases sofar. If you want, you can install the newest git with pip to see if it helps. There is no reason why controlling should not work on devices in other networks, discovery on the other hand is broadcast-based and will not be available there.
from pyhs100.
I don't know how to get the latest version from git, but I did find the relevant change needed in pyHS100.py and changed it. That did correct the issue in status.
-
Maybe add some self check by looking for local subnet and exit cleanly if IP used is not subnet and therefore broadcast would not work. Just an idea.
info = self.sys_info loc = {"latitude": None, "longitude": None} if "latitude" in info and "longitude" in info: loc["latitude"] = info["latitude"] loc["longitude"] = info["longitude"] elif "latitude_i" in info and "longitude_i" in info: loc["latitude"] = info["latitude_i"] loc["longitude"] = info["longitude_i"] else: _LOGGER.warning("Unsupported device location.") return loc
from pyhs100.
For discovery one should not define an IP at all, so I think having a check for broadcasting would be superfluous. Here's the documentation on how to use pip with version control systems: https://pip.pypa.io/en/stable/reference/pip_install/#vcs-support . The piece of code you found is indeed correct, are you having any other issues with your HS105 now?
from pyhs100.
I think this can be closed, please reopen / create a new issue if needed.
from pyhs100.
Related Issues (20)
- alias, state, and is_on not functional in SmartPlug for SmartStrip.plug[] devices HOT 2
- HS300 not listed in Discover.discover() HOT 4
- HS200 weird communication error HOT 6
- Security HOT 2
- New protocol HOT 5
- Add support for the KP200 HOT 23
- bug displaying plug status if off.
- New release? HOT 2
- LED config not working HOT 4
- view and update a schedule
- import failure HOT 5
- TP-link KP200 not working proper NOT A DUPLICATE OF ADD SUPPORT FOR THE KP200 HOT 1
- Smart Bulb KL50 HOT 3
- HS220 Set Brightness HOT 1
- Get rid of click-datetime dep HOT 2
- Archive this repository HOT 3
- Failed to run "$ pyhs100" after install HOT 2
- KP105 support HOT 1
- Run
- Kasa discovery HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyhs100.