Code Monkey home page Code Monkey logo

Comments (1)

timofurrer avatar timofurrer commented on June 14, 2024

The problem is that the dictionary keys are sorted before comparing them:

x_keys = list(sorted(X.keys()))

This is a problem if the key type is not sortable.
It's necessary because if the two dicts are not equal using X == Y, then a deep comparison is performed which need the keys to be sorted:

for key_X, key_Y in zip(x_keys, y_keys):

However, I think we can work around that, because from line 114 to 126 is already verified that the two dicts have the same keys, so the loop on 132 could just iterate the keys from the lhs dict in the given order and compare against the one on the rhs.

I hope I can provide a fix later today.

from sure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.