C++ Builder Errors in generated DSiWin32.hpp, OtlCommon.hpp, OtlSync.hpp about omnithreadlibrary HOT 11 OPEN

If you fix DSiWin32, I'll commit it.

from omnithreadlibrary.

The attached seems to produce a file that complies for c++ builder settle
DSiWin32.zip

what about OtlCommon.hpp and OtlSync.hpp ?

from omnithreadlibrary.

Added to the repository, thanks!

What about OtlCommon.hpp and OtlSync.hpp? Please keep in mind that I really know nothing about how C++Builder works with Delphi sources.

If you want anything changed, send me changes and I'll review and commit.

from omnithreadlibrary.

i know a little Delphi i'll see what i can workout. am i able to check these in myself to the repo? or do i need to upload them here?

from omnithreadlibrary.

OtlCommon.zip

I've looked at OtlCommon i've changed the duplicate proprieties names to have ByName or ByOV appended to them. i could not just exclude them from being added to the hpp files. hopefully this is only a minor change for everybody

__property TOmniValue AsArrayItemByName[const System::UnicodeString name] ={read=GetAsArrayItem, write=SetAsArrayItem};
__property TOmniValue AsArrayItemByOV[TOmniValue param] = {read=GetAsArrayItem, write=SetAsArrayItem};

__property TOmniValue ItemByName[const System::UnicodeString paramName] = {read=GetItem, write=SetItem};
__property TOmniValue ItemByOV[TOmniValue param] = {read=GetItem, write=SetItem};

OtlSync is proving to be more of an issue.

from omnithreadlibrary.

Sorry, but I will not commit a file that would change such a basic functionality for many users. The pascal side should stay - if at all possible - the same.

Is there a way to ifdef a code so it is ignored in the C++Builder? I would have no problems with this:

property AsArrayItem[idx: integer]: TOmniValue ...
property AsArrayItemByName[idx: integer]: TOmniValue ...
{$ifdef not-in-c}
property AsArrayItem[const name: string]: TOmniValue ....
{$endif}

This way Delphi users can use the code as they use it now and we have a new way to access the same functionality from both C++Builder and Delphi.

from omnithreadlibrary.

Yes i did i try that at first but could not seem to exclude them just for C++ which is why i did it the way i did. plus this causes issue in another file so i don't think that would work anyway,

Maybe you could see if its is possible, as i said i know a little Delphi and i can't see a way to do it.

Maybe one of your other users knows how to do it?

from omnithreadlibrary.

IFDEF BCB should do the trick: http://stackoverflow.com/questions/2627927/conditional-directive-to-identify-c-builder-personalities/2631343#2631343

This is how I imagined the new code:

property AsArrayItem[idx: integer]: TOmniValue
read GetAsArrayItem write SetAsArrayItem; default;
{$IFNDEF BCB}
property AsArrayItem[const name: string]: TOmniValue
read GetAsArrayItem write SetAsArrayItem; default;
{$ELSE}
property AsArrayItemByName[const name: string]: TOmniValue
read GetAsArrayItemByName write SetAsArrayItemByName;
{$ENDIF}

from omnithreadlibrary.

Hi i'll give it ago when i get a chance

Thanks

from omnithreadlibrary.

hello
in order to build DSiWin32 with bcb2007 I've had to introduce few more externalsym directives, please see attached version, note comments marked as // vavan

ouch. the page says "We don’t support that file type. with a PNG, GIF, JPG, DOCX, PPTX, XLSX, TXT, PDF, or ZIP" though I tried to upload zip

from omnithreadlibrary.

attached as txt
DSiWin32.txt

from omnithreadlibrary.