Building with fyne release does not set Metadata().Release to true about fyne HOT 11 CLOSED

What is the release of the fyne command line? (fyne --version)

from fyne.

I thought I could replicate this but I cannot. The fyne release command hard-codes release bool to true so I'm at a loss as to what is happening here...

from fyne.

The output of fyne --version is "fyne version v2.4.4"

I tried to run the above code with

• go run .
• fyne build (the built binary)
• fyne release (the built binary)

For each the string printed to terminal was test
The release should print out prod, correct?

from fyne.

Maybe this is for some reason a platform specific bug, are you trying to check this only on MacOS? Or also tried it on Windows and Linux? I do not have a windows install with the dev enviornment setup right now, I could check it another day on Windows if it could help track down the core of this issue

from fyne.

I tried to run the above code with

go run .
fyne build (the built binary)
fyne release (the built binary)

The last "the built binary" is concerning me - did you clear out the previous one before testing release? What was the path to the release binary that you tested?

from fyne.

I deleted the binary that built with fyne build first. Then I ran fyne release which created an archive which I extracted and ran that extracted binary

from fyne.

Can you please compile the tool locally with a log of "b.release" on line 199 of cmd/fyne/internal/commands/build.go (inside build() function). That way we can see if false is being passed in somehow. If so then a "debug.PrintStack" would help a lot.

from fyne.

Just so I understand you correctly, you would like for me to compile fyne v2.4.4 locally with the changes you requested above?

from fyne.

Locally compiled source code (go install .) for fyne v2.4.4 with the addition of "log.Println(b.release)".
Compiling the above code snippet with fyne release and running the built binary, metadata is false but the log during compiling is true.

Tried to do the same with "fyne package - os linux --release". Log during compile was true but after running the executed binary the metadata was true this time.

Doing the same with "fyne package - os linux" goes to false on both compile log and print of executed binary.

from fyne.

Thanks this has been very helpful, PR inbound

from fyne.

Resolved for v2.4.5 and 2.5 on develop

from fyne.