Interface of widget.TextSegment has been broken on develop about fyne HOT 12 CLOSED

(but we don't run anything like that on our documentation pages)

from fyne.

Ah yes. This does not actually print to the docs site, just generates images.
But I have fixed it for good measure.

from fyne.

This is not a breaking change because you are supposed to name the fields you set. Many code analysers even give you an error when you have unnamed struct parameters. If this was considered a breaking change, we would never be able to improve the types without introducing a new type i.e. every little improvement would be a breaking change. I will close this as not being an issue.

from fyne.

I see. Thanks for evaluating.

from fyne.

No worries. Thanks for keeping a close eye on the codebase

from fyne.

The OP is right it does feel like something broke (though I agree its not a breaking change).
What we may need to do however is to ensure any usage of struct literals in our codebase all use named fields ;).

from fyne.

What we may need to do however is to ensure any usage of struct literals in our codebase all use named fields ;).

I think Staticheck already flags that.

from fyne.

Yup. We should probably move the examples out into separate files (whose contents are added into the code blocks) and run code analysis on them?

from fyne.

JFYI: I did a quick grep with the expression \.[A-Z][a-zA-Z]*\{[^:}]+\} in the docs repo and only found some relevant results with color.NRGBA, color.Gray and color.RGBA in these files:

• _gen/genlayouts.go
• canvas/circle.md
• canvas/raster.md

I'm not sure, though, if these really need to be changed. I don't know what the policy about adding new fields to structs is in the standard library, but doubt that these three structs will ever change.

from fyne.

Thanks so much for that. We should fix them anyway, as @Jacalz said it's something linters complain about so our docs should this best practice!

from fyne.

Those instances should be fixed now :)

from fyne.

@andydotxyz canvas/circle.md and canvas/raster.md look good to me. In _gen/genlayouts.go I still see the "old" style in line 29 and line 32.

from fyne.