Default value of "manager-timeout" setting is incompatible with Composer 2.3+ about foxy HOT 2 CLOSED

I'll note that Foxy's behavior has always been wrong here-- the docblock for that Composer method has always specified that timeout should be an integer. It's only breaking now because Composer is enforcing that.

I feel like the fix here is to simply not call Composer\Util\ProcessExecutor::setTimeout() if "manager-timeout" is null, thereby keeping Composer's default timeout in place. I can submit a PR for this if that sounds okay.

from foxy.

The timeout could be null because the ProcessExecutor class uses the Symfony Process component whose timeout may be null, cf. the constructor of the Process class and that the property was not Typed. It was therefore reasonable to consider the PHP doc as incomplete, which often happens, and not as a deliberate choice of the developers.

Now that the property is Typed, it is therefore necessary to use the constant PHP_INT_MAX to obtain a pseudo equivalent to an unlimited timeout. The method Foxy\Config\Config::get() has a second argument to set a default value.

And any contribution is welcome :-)

from foxy.