Support writing to SDCards from within the Windows Subsystem for Linux about fwup HOT 9 CLOSED

Good point on msys.

Also, I haven't run this, but shouldn't "$FULLPATH" "$@" work for all cases? I'm trying to think about when fwup.exe would be someplace other than $FWUP_LOCATION/fwup.exe.

Could the script just be:

#!/usr/bin/env bash

FWUP_LOCATION="$(dirname "$(realpath "$0")")"
"$FWUP_LOCATION/fwup.exe" "$@"

Also, I dropped the exit $? since shell scripts return the exit status of the last program run by default. However, if Windows needs this, then please add back.

from fwup.

@michaelkschmidt - What do you think about adding the above script to the Chocolatey package? Do you see any issues?

from fwup.

@fhunleth This looks like a good start. We don't want to break fwup running under msys bash, though. How does this look?

#!/usr/bin/env bash
#
# Inspiration taken from Microsoft VS Code's Windows 'code' bash file

NAME="fwup"
FWUP_LOCATION="$(dirname "$(realpath "$0")")"

FULLPATH="$FWUP_LOCATION/$NAME.exe"
if grep -q Microsoft /proc/version; then
   # If running under WSL
 "$FULLPATH" "$@"
else
  fwup.exe "$@"
fi
exit $?

from fwup.

I've tested the above more concise fwup wrapper under WSL, cmd and powershell. It works well. It doesn't look like Windows needs the exit $?

from fwup.

Great! @jmerriweather Do you want the honors of submitting the PR? Sounds like the script just needs to be put in the scripts directory and a line added to copy it over here: https://github.com/fhunleth/fwup/blob/master/scripts/build_pkg.sh#L59.

from fwup.

Sure! I've submitted the PR #68

from fwup.

I just tested and the simplified script seems to still work with msys.

from fwup.

I just realized this issue is still open

@jsiems added a workaround in mix firmware.burn. See nerves-project/nerves#288

Do we still want a fwup only solution?

from fwup.

I think we can close this. If someone needs this outside of Nerves, we can point them to what was done there. My hunch is that fwup has very few WSL users outside of those using Nerves.

from fwup.