Comments (9)
Good point on msys
.
Also, I haven't run this, but shouldn't "$FULLPATH" "$@"
work for all cases? I'm trying to think about when fwup.exe
would be someplace other than $FWUP_LOCATION/fwup.exe
.
Could the script just be:
#!/usr/bin/env bash
FWUP_LOCATION="$(dirname "$(realpath "$0")")"
"$FWUP_LOCATION/fwup.exe" "$@"
Also, I dropped the exit $?
since shell scripts return the exit status of the last program run by default. However, if Windows needs this, then please add back.
from fwup.
@michaelkschmidt - What do you think about adding the above script to the Chocolatey package? Do you see any issues?
from fwup.
@fhunleth This looks like a good start. We don't want to break fwup running under msys
bash, though. How does this look?
#!/usr/bin/env bash
#
# Inspiration taken from Microsoft VS Code's Windows 'code' bash file
NAME="fwup"
FWUP_LOCATION="$(dirname "$(realpath "$0")")"
FULLPATH="$FWUP_LOCATION/$NAME.exe"
if grep -q Microsoft /proc/version; then
# If running under WSL
"$FULLPATH" "$@"
else
fwup.exe "$@"
fi
exit $?
from fwup.
I've tested the above more concise fwup wrapper under WSL, cmd and powershell. It works well. It doesn't look like Windows needs the exit $?
from fwup.
Great! @jmerriweather Do you want the honors of submitting the PR? Sounds like the script just needs to be put in the scripts directory and a line added to copy it over here: https://github.com/fhunleth/fwup/blob/master/scripts/build_pkg.sh#L59.
from fwup.
Sure! I've submitted the PR #68
from fwup.
I just tested and the simplified script seems to still work with msys
.
from fwup.
I just realized this issue is still open
@jsiems added a workaround in mix firmware.burn
. See nerves-project/nerves#288
Do we still want a fwup
only solution?
from fwup.
I think we can close this. If someone needs this outside of Nerves, we can point them to what was done there. My hunch is that fwup
has very few WSL users outside of those using Nerves.
from fwup.
Related Issues (20)
- Could anyone help me move CI from Travis-CI to anywhere else? HOT 1
- fsck.fat v4.2 failure HOT 4
- question: sometimes, for ext4 partition, no sparse compression is done HOT 4
- Failed to start File System Check on Root Device HOT 6
- fwup:amd64 : Depends: libc6:amd64 (>= 2.4) but it is not installable HOT 8
- Add `.deb` for `aarch64` to the releases
- zlib-1.2.11 is no longer available from zlib.net HOT 3
- Add lock file support
- Support usb drive or card reader HOT 4
- Compiling with glibc 2.36 fails due to conflicting headers HOT 1
- xdelta tries to read too much data HOT 5
- Handle /dev/null as a special case output device HOT 4
- Support delta-source-fat-offset and delta-source-fat-path HOT 4
- Arm build is missing from releases. HOT 1
- u-boot redundant environment support issue HOT 5
- UMS is not detected by fwup on Windows 11 HOT 5
- fwupd defeated by secure boot kernel lockdown? HOT 1
- Test failure installing 1.10.1 HOT 3
- Suggestion: Ignore tiny discovered drives/devices HOT 4
- Signing firmware files post-delta creation fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fwup.