Wrap register_as_guest! in transaction about cubecomp HOT 3 CLOSED

Yeah I thought about that earlier, haven't found a good solution yet.

The only place where this is used so far is the admin/competitors controller and those are wrapped in a transaction already. If register_as_guest! and the others in that file fail, I want it to rollback the whole transaction here. But if I wrap those methods themselves in transactions as well, that wont work because MySQL doesn't support nested transactions.

Any ideas on how to make this better? I guess I could check if register_as_guest! etc. rolled back, and if so, manually raise an ActiveRecord::Rollback? Not sure if that would work.

from cubecomp.

I think the whole thing there is a little bit ugly. I tried to make it work with nested_attributes before, but that ended up being more complicated because the way I want the form to look doesn't map nicely to the data model.

from cubecomp.

Oh, nice, haven't looked at the controllers, yet. Not sure if it still needs its own transaction. Need to dive deeper into the code.

But if I wrap those methods themselves in transactions as well, that wont work because MySQL doesn't support nested transactions.

ActiveRecord seems to emulate nested transactions using savepoints (http://api.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html). Not sure if that has the same guarantees as a transaction, though (the wiki article).

Yeah, it's not the prettiest code, but I also don't have a decent way to clean it up, yet. Maybe some object which knows how to build the data model from the form parameters?

from cubecomp.