Compile-time option to have @shutdown and @restart generate different process exit codes about fuzzball HOT 7 CLOSED

I agree. Would allow for hooking actual restart functions, and even better if it were configurable, since that would provide easy functionality for any custom situational restart need that may arise.

Aside from the fact that it really isn't necessary to have two commands do identical things, whole idea just sounds like good sense and good coding IMO.

from fuzzball.

I didn't check to see if @armageddon also generates a zero exit code. If so, I would definitely suggest lumping that in with the above.

from fuzzball.

This is a good idea. It prompted me to review exit codes for the main server. The main ones seem to be:

code 1:
invalid syntax or inconsistent options
cannot spawn resolver
cannot set socket options
setuid/setguid issues
@armageddon

code 2:
problem loading database

code 3:
output file the same as input file (with DISKBASE on)
cannot create socket

code 4:
cannot cd to game directory
cannot bind socket

code 7:
signal received - bailout

So, compile-time options RESTART_EXIT_CODE (default 0) and ARMAGEDDON_EXIT_CODE (default 1) seem appropriate. Any other option or standardization recommended? It would seem that exit codes 2-4 could just use code 1, but there may be a good reason for the way it is.

from fuzzball.

I am hesitant to change any existing behaviors. Perhaps assign an unused exit code to @restart, and leave @shutdown as 0?

from fuzzball.

Yeah, @shutdown would remain 0. I can change the default for RESTART_EXIT_CODE to 5.

from fuzzball.

Per our conversation on SPR, I'll proceed with compile-time options RESTART_EXIT_CODE (default 0) and ARMAGEDDON_EXIT_CODE (default 1). Look for those soon.

from fuzzball.

Compile-time options RESTART_EXIT_CODE (default 0) and ARMAGEDDON_EXIT_CODE (default 1) have been added to include/config.h .

from fuzzball.