navigationState duplicate key when restarting the app after an error about pepperoni-app-kit HOT 4 CLOSED

I have narrowed down this issue to this line:
https://github.com/futurice/pepperoni-app-kit/blob/master/src/modules/navigation/NavigationState.js#L48

in react-native:
https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/Reducer/NavigationScenesReducer.js#L125

also found this related issues with a good description: jlyman/RN-NavigationExperimental-Redux-Example#10

proposed fix:

const getNewChildrenList = (children) => {
    const sameChildren = children.filter((child) => {
        return child.get('key') === (action.payload && action.payload.key);
    });
    if (sameChildren.isEmpty()) {
        children.push(fromJS(action.payload));
    }
    return children;
}
return state
    .set('isNavigating', true)
        .updateIn(['children', state.get('index')], tabState =>
            tabState
                .update('children', getNewChildrenList)
                .set('index', tabState.get('children').size);
        );

Basically it checks that the child is not already present before pushing it in.
At the moment this solution doesn't work 100%, because the index between NavigationState and Scenes goes out of sync.
But hopefully this will help help others with this same issue

from pepperoni-app-kit.

@fabriziomoscon is this issue solved by #89 or is there something more we need to do in your opinion?

from pepperoni-app-kit.

@jevakallio I haven't see this issue at all after implementing the change in PR #89
I think this is the fix: https://github.com/futurice/pepperoni-app-kit/blob/master/src/modules/navigation/NavigationState.js#L61-L68

from pepperoni-app-kit.

Awesome 🎉

from pepperoni-app-kit.