Comments (1)
Thanks for filing this!
We should avoid binding window
to any provided fetch implementation, as we make no assumptions on the context for the function call. For example, unfetch
is fairly popular to provide better browser support.
I'll create a PR to update our documentation to avoid registering window.fetch
directly. A simple solution would be to register an already bound window.fetch
. Something like:
const app = new App(/*some root*/);
__BROWSER__ && app.register(FetchToken, fetch.bind(window));
Closing this, but happy to revisit if you have other thoughts.
from fusion-plugin-universal-events.
Related Issues (20)
- Support * event type for handlers and mappers
- Ensure global mappers and handlers are called for events emitted from ctx scoped emitter
- Action Required: Fix Renovate Configuration
- Use navigator.sendBeacon when available
- Allow server-side global emission with ctx
- Fix bug with server side event batching
- Fix bug where mappers were run before batch was flushed
- Use Buildkite and Docker for CI
- Migrate fusion-plugin-universal-events to DI
- Migrate fusion-plugin-universal-events to createPlugin
- Test issue
- Test issue
- Pass string to createToken for better error messages
- Migrate to new fusion-tokens api
- Batch events emitted from `EventEmitter.of(ctx)`
- Add Token dependencies to readme
- Add support for cleanup function
- Update dependencies
- Fix flow types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fusion-plugin-universal-events.