Hi, when using whois with proxy option, and the socks client raise error the code(

Thx for this fix, lol <a class="user-mention notranslate" data-hovercard-type="user" d

TypeError: cannot destructure property 'socket' when using proxy and the connection established failed about node-whois HOT 5 CLOSED

KEXUJIAN commented on September 23, 2024 2

TypeError: cannot destructure property 'socket' when using proxy and the connection established failed

from node-whois.

Comments (5)

ozkanpakdil commented on September 23, 2024

are there any "work around" for this problem ? nodejs newbie here

from node-whois.

leadscloud commented on September 23, 2024

same error

from node-whois.

leadscloud commented on September 23, 2024

same error

when set proxy with timeout often get this error.

/node_modules/whois/index.js:156
      }, (err, {socket}) => {
                ^

TypeError: Cannot destructure property 'socket' of 'undefined' as it is undefined.

return SocksClient.createConnection({
        proxy: proxy,
        destination: {
          host: server.host,
          port: server.port
        },
        command: 'connect',
        timeout: timeout
      }, (err, {socket}) => {
        if (err != null) {
          return done(err);
        }
        if (timeout) {
          socket.setTimeout(timeout);
        }
        _lookup(socket, done);
        return socket.resume();
      });

from node-whois.

KEXUJIAN commented on September 23, 2024

are there any "work around" for this problem ? nodejs newbie here

This is a small problem but, maybe the author doesn't maintain this lib, unfortunately

I have no experience on opening a mr and not familiar with coffee script yet.

If someone met this error can access and modify the dist index.js file, you can change these lines below (line: 156)

if (proxy) {
  return SocksClient.createConnection({
      // args ...
  }, (err, {socket}) => {
    if (err != null) {
      return done(err);
    }
    if (timeout) {
      socket.setTimeout(timeout);
    }
    _lookup(socket, done);
    return socket.resume();
  });
}

if (proxy) {
  return SocksClient.createConnection({
      // args ...
  }, (err, resp) => {
    if (err != null) {
      return done(err);
    }
    const { socket } = resp
    if (timeout) {
      socket.setTimeout(timeout);
    }
    _lookup(socket, done);
    return socket.resume();
  });
}