Comments (3)
Thanks for the report. I hopefully fixed this several weeks ago. Can you
please try the latest master?
Another question - why do you suggest catching OSError
as well?
Finally, I'd like to cover it with unittest. Do you have a suggestion on
how to write it?
On Nov 14, 2015 16:16, "Timu Eren" [email protected] wrote:
While try to not existed database with not existed user ioloop raise
IOError, momoko silently pass the connection error and file descriptor not
exists at the time, and we can't catch this exception in our application.we find a solution for this problem changing lines inside of
momoko.connection.py between 706 and 714,try: if state == POLL_OK: self.ioloop.remove_handler(self.fileno) future.set_result(result) elif state == POLL_READ: self.ioloop.update_handler(self.fileno, IOLoop.READ) elif state == POLL_WRITE: self.ioloop.update_handler(self.fileno, IOLoop.WRITE) except (IOError, OSError): future.set_exception(psycopg2.OperationalError("poll() returned %s" % state))
Exception:
[E 151114 15:58:16 ioloop:612] Exception in callback (10, )
Traceback (most recent call last):
File
"/home/timu/workspace/video-ad-server/frontend/.env/local/lib/python2.7/site-packages/tornado/ioloop.py",
line 866, in start
handler_func(fd_obj, events)
File
"/home/timu/workspace/video-ad-server/frontend/.env/local/lib/python2.7/site-packages/tornado/stack_context.py",
line 275, in null_wrapper
return fn(_args, *_kwargs)
File
"/home/timu/workspace/video-ad-server/frontend/.env/local/lib/python2.7/site-packages/momoko/connection.py",
line 712, in _io_callback
self.ioloop.update_handler(self.fileno, IOLoop.WRITE)
File
"/home/timu/workspace/video-ad-server/frontend/.env/local/lib/python2.7/site-packages/tornado/ioloop.py",
line 708, in update_handler
self._impl.modify(fd, events | self.ERROR)
IOError: [Errno 2] No such file or directory—
Reply to this email directly or view it on GitHub
#133.
from momoko.
I try with master and i corrected this issue fixed,
Actually i dont have good reason to catch OSError, i copy/paste this catch block from somewhere else.
i dont have to any suggestion for unit testing, but may be this is help:
I use pool object but probably is the same with single connection object
def testIOError(self):
self.ioloop.add_future(pool_instance_with_bad_dsn.connect(), self.is_executed)
def is_executed(self, future):
self.assert(True)
from momoko.
Great. I'll try to release the new version based on the master during the
upcoming week.
On Sat, Nov 14, 2015 at 11:12 PM, Timu Eren [email protected]
wrote:
I try with master and i corrected this issue fixed,
Actually i dont have good reason to catch OSError, i copy/paste this catch
block from somewhere else.i dont have to any suggestion for unit testing, but may be this is help:
I use pool object but probably is the same with single connection object
def testIOError(self):
self.ioloop.add_future(pool_instance_with_bad_dsn.connect(), self.is_executed)
def is_executed(self, future):
self.assert(True)—
Reply to this email directly or view it on GitHub
#133 (comment).
Zaar
from momoko.
Related Issues (20)
- Behavior of .execute() wo parameters does not match psycopg2 HOT 1
- code in ConnectionContainer.all_dead conflicts with Pool.putconn HOT 4
- The future returned by Connection.execute will never resolve HOT 1
- self.conns.empty() in Pool.close will not work as expected by big chance HOT 3
- How can I run the first sample of momoko HOT 6
- Pool fails to reconnect when using Unix-domain socket (OperationalError: server closed the connection unexpectedly) HOT 18
- Restarting PostgreSQL sometimes causes Pool.getconn() to hang HOT 5
- Momoko Pool trying to use dead connections HOT 3
- Writing tests for tornado app, which uses momoko for postgres DB. HOT 2
- Cannot add momoko HOT 1
- Please help me figure out why this code freezes forever HOT 8
- Any suggestion on how I'd commit/rollback using a connection pool? HOT 3
- when using RealDictCursor, Pool.register_json error HOT 2
- Typo in connection.py (socker instead of socket) HOT 2
- error if trying to connect pool while Postgress is not online HOT 2
- NamedTupleCursor factory test is executed even if MOMOKO_TEST_HSTORE is disabled HOT 1
- Debian packaging HOT 1
- AttributeError: 'Future' object has no attribute 'set_exc_info' HOT 5
- Not worked with python 3.7 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from momoko.