Reorder open statements about fantomas HOT 12 CLOSED

Presumably into alphabetical order.

from fantomas.

Removing unused ones would be a nice extra, but I'm guessing it's much harder to implement, and alphabetical sort would be already very good

from fantomas.

Sorting open statements is easy but removing unused ones is difficult.

The latter requires a type-checking phase which hasn't been implemented in Fantomas yet. I think the feature is in the scope of fsharp-refactor.

from fantomas.

Removing duplicates will be useful.

from fantomas.

This was already done in #51

from fantomas.

Reopening, as I had to disable this because of #73
@dungpa any ideas how we can do this more safely

from fantomas.

We can add special treatments for open declarations in TokenMatcher module. The module should recognize the whole lines of open declarations and skip them although module names don't match.

from fantomas.

What if there are comments between the open declarations? Before I disabled this feature, this:

//comment about System.IO
open System.IO
//comment about System
open System

Was being turned to this:

//comment about System.IO
open System
//comment about System
open System.IO

Is this acceptable or should we output this instead?

//comment about System
open System
//comment about System.IO
open System.IO

I'm gessing your proposed solution would output this:

//comment about System.IO
//comment about System
open System
open System.IO

Maybe this case is rare enough that even if we don't get it exactly right it's ok.

from fantomas.

Yes, we are more likely to arrive at the last example. The second one is of course ideal.

I will try to improve TokenMatcher and see how far we can go.

from fantomas.

@dsyme What do you suggest on this? It seems we can't reorder open statements without losing some comments around them.

from fantomas.

@dungpa any progres on the TokenMatcher changes?

from fantomas.

Not yet. I will work on that tomorrow.

from fantomas.