Comments (8)
I'll get to it unless it is breaking anyone right now or is urgent, as I'd like to just grasp the thing some more and get familiar with how tests are done in the repository.
from fsharp.stats.
Of course!
The TestDataSAM.txt file is located in FSharp.Stats\tests\FSharp.Stats.Tests\data\TestDataSAM.txt
.
Also, you can find a copy of it attached here:
TestDataSAM.txt
from fsharp.stats.
@zieglerSe sorry for having missed it in the repository and thanks for the other PR to adjust the docs, I'll be able to proceed if I see further adjustments to suggest.
In #272 where I'm suggesting some changes in the overall code (not SAM only), there is seemingly a missing check for -infinity
in the implementation of SAM, could you confirm if this is an oversight in which case I'll try to adjust a test case that would cover it and add the check for -infinity
.
Thanks!
from fsharp.stats.
@smoothdeveloper no problem!
I saw #272 and checked it - the missing check for -infinity
was an oversight. Feel free to add the changes, otherwise i'll take care of it!
from fsharp.stats.
A small note about the SAM
record, it has the ID
field hardcoded to string
but I believe we'd want to make this a generic type parameter (that is IComparable
).
I've not looked how it would impact client code, but unless there is a "ID" of items we put in SAM is settled to be a string, always, I think it is worth adjusting to make it generic.
The main caveat is, people who haven't used statically typed languages, with generics, may find this a bit "head scratching" at first.
If there is interest, I'll make separate issue and check the outcome of making this record field generic.
from fsharp.stats.
I agree, that a generic type for the ID field would be beneficial. The only draw back I can see is, that the type would contain a generic type annotation which makes the type a little bit more complex but the benefit definetely greater.
Testing.SAM.SAMResult becomes Testing.SAM.SamResult<'a>
While in most cases the identifier would be a UniProt accession number (string
) or some other kind of domain-id, it definetely is possible to have e.g. BioFSharp.IO.FastA.FastaItem<BioArray<Nucleotide>>
as bioitem identifier.
If you want, you can take care of it, or I can quickly modify the SAM type🚀
from fsharp.stats.
@bvenn, I'll make a PR for the ID
field so we can review the impact, you are right, it bubbles to SAMResult as well. Thanks for the feedback!
from fsharp.stats.
Closing the issue as the fixed documentation has made it online :)
from fsharp.stats.
Related Issues (20)
- t-Distributed Stochastic Neighbour Embedding (tSNE)
- Decision trees and random forest
- kNN classification HOT 1
- Documentation request for X² test
- [Feature Request] Surface fitting for simple data, and example that shows the surface in plotly HOT 5
- [Feature Request] NaN safety, we probably need something more than doc strings. HOT 2
- [Feature Request] review / remove [<AutoOpen>] on modules that overlay FSharp.Core collection types. HOT 2
- [Feature Request]addition of Normalized Mutual Information
- [BUG] Incorrect Behavior in FSharp.Stats.SpecializedGenericImpl.setColM for Non-Square Matrices
- [Feature Request] QR Matrix Decomposition using Gram-Schmidt HOT 2
- [Feature Request] weighted KNN imputation
- `JaggedCollection.transpose` results in wrong result when applied to rows of varying length
- [BUG] HierarchicalClustering cannot digest data of generic type anymore
- [BUG] Interval.isIntersection false positive on one-sided open intervals HOT 1
- [Feature Request] Support intersect on mixed interval types
- [BUG] Seq.weightedMean returns a function
- [BUG] Seq.stats returns wrong seq length (N)
- [Feature Request] Rename round operator HOT 1
- Update fsdocs to new documentation template HOT 1
- [BUG] ApiDocs github links go to the wrong branch.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsharp.stats.