Comments (3)
zyzhu
commented on July 22, 2024
I am not sure the first option to create a generic class is doable. In your case, you overloaded the operators on price and quantity properties. But there are infinite scenarios of classes. Users of Deedle library shall not expect to inherit a base class from Deedle so as to get the operator overloaded. The operators are supposed to be overridden for each scenario.
As for the second part, I'm afraid I cannot offer any help. I barely write C# code.
from deedle.
b-twis
commented on July 22, 2024
HI zyzhu,
Thank you for the response. I understand there are infinite scenarios when implementing generics, but thought I would ask.
I dont need the c# code as such, more an explanation of the F# code so I could attempt to reimplement it in c#.
static member inline internal VectorOperation<'T>(series1:Series<'K,'T>, series2:Series<'K,'T>, op): Series<_, 'T> =
let newIndex, lcmd, rcmd =
createJoinTransformation series1.IndexBuilder series2.IndexBuilder
JoinKind.Outer Lookup.Exact series1.Index series2.Index (Vectors.Return 0) (Vectors.Return 1)
let vecRes = Vectors.Combine(lazy newIndex.KeyCount, [lcmd; rcmd], BinaryTransform.CreateLifted<'T>(op))
let vector = series1.VectorBuilder.Build<'T>(newIndex.AddressingScheme, vecRes, [| series1.Vector; series2.Vector |])
Series(newIndex, vector, series1.VectorBuilder, series1.IndexBuilder)I prototyped something like the following, which kind of got me what I was looking for however I never got to finishing the Vector Operation class or implementing the Scalar Operations into DeliverySeries.
Just leaving it here in case someone has thoughts, or is looking for something similar.
public class DeliverySeries : Series<DateTimeDST, OptionalValue<DeliverySlot>>
{
public DeliverySeries(IEnumerable<KeyValuePair<DateTimeDST, OptionalValue<DeliverySlot>>> pairs) : base(pairs)
{
}
public DeliverySeries(DateTimeDST[] keys, OptionalValue<DeliverySlot>[] values) : base(keys, values)
{
}
public DeliverySeries(IEnumerable<DateTimeDST> keys, IEnumerable<OptionalValue<DeliverySlot>> values) : base(keys, values)
{
}
public static DeliverySeries operator +(DeliverySeries a) => a;
public static DeliverySeries operator -(DeliverySeries a) => new DeliverySeries(a.Keys, a.Values.Select(x => new OptionalValue<DeliverySlot>(-x.Value)));
private static DeliverySeries VectorOperation(DeliverySeries a, DeliverySeries b, string op)
{
var unionKeys = a.Keys.Union(b.Keys).Distinct().OrderBy(x => x).ToArray();
OptionalValue<DeliverySlot>[] cValues = new OptionalValue<DeliverySlot>[unionKeys.Count()];
for (int i = 0; i < unionKeys.Length; i++)
{
if (a.ContainsKey(unionKeys[i]) && b.ContainsKey(unionKeys[i]))
{
var aValue = a.Get(unionKeys[i]);
var bValue = b.Get(unionKeys[i]);
switch (op)
{
case "+":
cValues[i] = new OptionalValue<DeliverySlot>(aValue.Value + bValue.Value);
break;
case "-":
cValues[i] = new OptionalValue<DeliverySlot>(aValue.Value - bValue.Value);
break;
case "*":
cValues[i] = new OptionalValue<DeliverySlot>(aValue.Value * bValue.Value);
break;
case "/":
cValues[i] = new OptionalValue<DeliverySlot>(aValue.Value / bValue.Value);
break;
}
}
else
{
cValues[i] = new OptionalValue<DeliverySlot>();
}
}
return new DeliverySeries(unionKeys, cValues);
}
public static DeliverySeries operator +(DeliverySeries a, DeliverySeries b)
{
return VectorOperation(a, b, "+");
}
public static DeliverySeries operator -(DeliverySeries a, DeliverySeries b)
{
return VectorOperation(a, b, "-");
}
public static DeliverySeries operator *(DeliverySeries a, DeliverySeries b)
{
return VectorOperation(a, b, "*");
}
public static DeliverySeries operator /(DeliverySeries a, DeliverySeries b)
{
return VectorOperation(a, b, "/");
}
}
public readonly struct DeliverySlot : IEquatable<DeliverySlot>, ICloneable
{
private readonly decimal _quantity;
private readonly decimal _price;
public DeliverySlot(decimal quantity, decimal price)
{
_quantity = quantity;
_price = price;
}
public static DeliverySlot operator +(DeliverySlot a) => a;
public static DeliverySlot operator -(DeliverySlot a) => new DeliverySlot(-a._quantity, a._price);
//series,series
public static DeliverySlot operator +(DeliverySlot a, DeliverySlot b)
=> new DeliverySlot(a._quantity + b._quantity, Math.Max(a._price, b._price));
public static DeliverySlot operator -(DeliverySlot a, DeliverySlot b)
=> new DeliverySlot(a._quantity - b._quantity, a._price);
public static DeliverySlot operator *(DeliverySlot a, DeliverySlot b)
=> new DeliverySlot(a._quantity * b._quantity, Math.Max(a._price, b._price));
public static DeliverySlot operator /(DeliverySlot a, DeliverySlot b)
=> new DeliverySlot(a._quantity / b._quantity, Math.Max(a._price, b._price));
// series, decimal
public static DeliverySlot operator +(DeliverySlot a, decimal b)
=> new DeliverySlot(a._quantity + b, a._price);
public static DeliverySlot operator -(DeliverySlot a, decimal b)
=> new DeliverySlot(a._quantity - b, a._price);
public override bool Equals(object obj)
{
return (obj is DeliverySlot) && Equals(obj);
}
public bool Equals(DeliverySlot other)
{
return this.GetHashCode() == other.GetHashCode();
}
public override int GetHashCode()
{
int iHash = 0;
iHash ^= (23 * 37) + _quantity.GetHashCode();
return iHash;
}
public object Clone()
{
return this.MemberwiseClone();
}
}
public class DateTimeDST : IEquatable<DateTimeDST>, IComparable<DateTimeDST>, ICloneable
{
private readonly DateTime _datetime;
public DateTime DateTime
{
get
{
return _datetime;
}
}
private readonly bool _dst;
public bool DST
{
get
{
return _dst;
}
}
public DateTimeDST(DateTime dateTime)
{
_datetime = dateTime;
_dst = false;
}
public DateTimeDST(string dateTime)
{
_datetime = DateTime.Parse(dateTime);
_dst = false;
}
public DateTimeDST(DateTime dateTime, bool isDST)
{
_datetime = dateTime;
_dst = isDST;
}
public DateTimeDST(string dateTime, bool isDST)
{
_datetime = DateTime.Parse(dateTime);
_dst = isDST;
}
public static explicit operator DateTime(DateTimeDST thisDateTimeDST)
{
return thisDateTimeDST._datetime;
}
public override bool Equals(object obj)
{
return Equals(obj as DateTimeDST);
}
public bool Equals(DateTimeDST other)
{
return this.GetHashCode() == other?.GetHashCode();
}
public override int GetHashCode()
{
int iHash = 0;
iHash ^= (23 * 37) + _datetime.GetHashCode();
iHash ^= (23 * 37) + _dst.GetHashCode();
return iHash;
}
public int CompareTo(DateTimeDST compareDate)
{
if (compareDate is null)
throw new ArgumentNullException(nameof(compareDate));
int result = DateTime.CompareTo(compareDate.DateTime);
if (result == 0)
result = DST.CompareTo(compareDate.DST);
return result;
}
public object Clone()
{
return this.MemberwiseClone();
}
}from deedle.
zyzhu
commented on July 22, 2024
As you already overloaded the operators on DeliveryShot, you may use Zip function to zip two series together and apply your overloaded operators such as the following.
var s1 = new SeriesBuilder<DateTime, DeliverySlot>
{
{ DateTime.Parse("2020-01-01 01:00"), new DeliverySlot(1.0M, 1.0M) },
{ DateTime.Parse("2020-01-01 02:00"), new DeliverySlot(2.0M, 2.0M) },
{ DateTime.Parse("2020-01-01 03:00"), new DeliverySlot(3.0M, 3.0M) }
}.Series;
var s2 = new SeriesBuilder<DateTime, DeliverySlot>
{
{ DateTime.Parse("2020-01-01 01:00"), new DeliverySlot(1.0M, 1.0M) },
{ DateTime.Parse("2020-01-01 02:00"), new DeliverySlot(2.0M, 2.0M) },
{ DateTime.Parse("2020-01-01 03:00"), new DeliverySlot(3.0M, 3.0M) }
}.Series;
var s3 = s1.Zip(s2).Select(kvp => kvp.Value.Item1.Value + kvp.Value.Item2.Value);The above snippet doesn't check missing values. Make sure you check whether each value HasValue before running operators.
from deedle.
Related Issues (20)
- series.GetKeyAt and frame.GetRowKeyAt take different types for index. Seems inconsistent. HOT 1
- Move to netstandard2.0 only and decouple from RProvider for now HOT 2
- Converted code to Deedle HOT 6
- Truncate part of a Frame HOT 1
- Sample code snippet and introduction for the fslab website HOT 2
- Signature of Matrix.dot is unnecessarily limited HOT 3
- Breaking change for Min/Max stats function between v2.1.0 and 2.1.1 HOT 2
- Frame.mapColValues is weirdly slow compared to mapping columns as series and joining with Frame.ofColumns HOT 1
- Frame.toArray2D throws a System.Format exception HOT 1
- Optionalvalue ignores culture
- "Select not supported" for GetRowsAs<'T>
- FSLab page out of date, not working HOT 1
- Unable to load text file with space seperated
- Stats.cov throws if Stats.stdDev contains missing values HOT 2
- Change melt to have optional parameters in line with Pandas DateFrame and R's data.table
- Deedle Finance.ewmVol is returning the rolling mean not the standard deviation HOT 1
- Exporting frames to a json
- Suggestion to distinct rows by specified columns HOT 2
- Series.windowSize throws IndexOutOfRangeException when size is bigger than input series length HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deedle.