[Potential Bug] Changeset.ValidateRequired doesn't produce error for required field about grimoire HOT 2 CLOSED

Thanks for the reply.

Yes, I'm willing to work on this issue. Will add pull request soon 😃

from grimoire.

Hi, Thanks for this very detailed bug.

Yes, you are correct, the problem is indeed in this line (https://github.com/Fs02/grimoire/blob/master/changeset/validate_required.go#L27).

type fichaURL string cannot be checked as a normal string because the type is aliased as fichaURL. therefore it skipped the string empty check.

One possible solution I can think of for custom type is maybe to implement an isZeroer interface and adds check for type that interface in validate required.

type isZeroer interface{
  IsZero() bool
}

isZeroer should be pretty simple to implement and it's also compatible with other type such as time. https://golang.org/pkg/time/#Time.IsZero

Let me know if you are willing to open pull request for this bug 😄

from grimoire.