Problem in Exception.php with shutdownHandler() about apix HOT 3 CLOSED

frqnck commented on August 26, 2024

Problem in Exception.php with shutdownHandler()

from apix.

Comments (3)

frqnck commented on August 26, 2024

Could you send me a short example so I can try it out here.

On 20 Mar 2014, at 15:22, Jonathan [email protected] wrote:

Not sure the best way to fix as I haven't spent any time messing with it yet, but figure you have a good idea of how to solve this. It might be as simple as turning the DEBUG constant here to "false".

If there is an error in an internal function (database query, json_encode, etc) and it is caught and handled appropriately by the user, error_get_last() still returns the error. This means that we can intend to return an appropriate response to the user, but it will have a 500 appended (in HTML) to the response.

—
Reply to this email directly or view it on GitHub.

from apix.

jspalink commented on August 26, 2024

Here is an example controller that you can use to replicate:

<?php

namespace Controllers;

/**
 * Test controller
 */
class Test
{

    /**
     * Test
     * 
     * Just a quick test
     *
     * @return      array               An array representing a category
     */
    public function onRead() {
        try {
            $response = json_decode();
        } catch (Exception $e) {
            $response = "caught an error";
        }

        return array($response);
    }
}

The response looks like this:

{
    "myapi": {
        "test": [
            null
        ],
        "signature": {
            "resource": "GET \/test",
            "status": "200 OK - successful",
            "client_ip": "127.0.0.1"
        },
        "debug": {
            "timestamp": "Thu, 20 Mar 2014 15:27:37 GMT",
            "request": "GET \/api\/v2\/test HTTP\/1.1",
            "headers": {
                "Vary": "Accept"
            },
            "output_format": "json",
            "router_params": [

            ],
            "memory": "1.42 MB~1.44 MB",
            "timing": "0.01 seconds"
        }
    }
}<h1>500 Internal Server Error</h1>#2 Shutdown:- json_decode() expects at least 1 parameter, 0 given @ /home/jspalink/dev/my-api/Controllers/Test.php:31

from apix.

frqnck commented on August 26, 2024

Okay. This has now been fixed. There are 3 case scenarios as follow:

1. The error is NOT caught.

...
    $response = json_decode();
}

which results in

{
    "apix": {
        "error": {
            "message": "json_decode() expects at least 1 parameter, 0 given",
            "code": 500
        },
        "signature": {
            "resource": "GET \/bug",
            "status": "500 Internal Server Error - failed",

2. The error is caught and re-thrown

try {
    $response = json_decode();
} catch (\Exception $e) {
    $response = "caught an error";
    throw new \Exception($response);
}

which results in

 "apix": {
       "error": {
           "message": "caught an error",
           "code": 500
       },
       "signature": {
           "resource": "GET \/bug",
           "status": "500 Internal Server Error - failed",
…

3. The error is caught but NOT re-thrown (not advised)

try {
    $response = json_decode();
} catch (\Exception $e) {
    $response = "caught an error";
}

which results in

 "apix": {
       "test": [
           "caught an error"
       ],
       "signature": {
           "resource": "GET \/bug",
           "status": "200 OK - successful",
...

from apix.

Problem in Exception.php with shutdownHandler() about apix HOT 3 CLOSED

Comments (3)

Related Issues (4)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent