Fails in submodules about legit HOT 5 CLOSED

Hmm, that shouldn't be the case. Interesting.

from legit.

Fixed!

from legit.

I saw you merged that. It still doesn't work for me.

from legit.

I haven't pushed a new release yet.

from legit.

@kennethreitz
Re-open, please.

What commit/change should have fixed this?
Because it's not fixed for me, using the develop branch.

The problem currently appears to be that git.Repo() does not handle submodules via .git files, but tests for .git to be a dir.

I could imagine a workaround being to resolve the workdir in legit before calling Repo():

1. use git rev-parse --git-dir (instead of --show-toplevel) to get the submodule's/repo's git dir
2. set working_dir for the repo instance manually, based on finding ".git" (file and dir) in the current dir or above.

That is what the fix for GitPython does also: (gitpython-developers/GitPython#89):

+          if is_git_dir(gitpath):
+            self.git_dir = gitpath
+            self._working_tree_dir = curpath

from legit.