Code Monkey home page Code Monkey logo

Comments (5)

kumekay avatar kumekay commented on July 18, 2024 2

I experienced this issue using webpack.
More details on this issue reactjs/react-modal#133

I worked around it by adding

import Modal from 'react-modal';
   componentWillMount() {
        Modal.setAppElement('body');
    }

Full example

import React, {Component} from 'react';
import Lightbox from 'react-image-lightbox';
import Modal from 'react-modal';

const images = [
    '//placekitten.com/1500/500',
    '//placekitten.com/4000/3000',
    '//placekitten.com/800/1200',
    '//placekitten.com/1500/1500'
];

export default class Gallery extends Component {
    constructor(props) {
        super(props);

        this.state = {
            photoIndex: 0,
            isOpen: false
        };
    }

    componentWillMount() {
        Modal.setAppElement('body');
    }

    render() {
        const {
            photoIndex,
            isOpen
        } = this.state;

        return (
            <div>
                <button
                    type="button"
                    onClick={() => this.setState({isOpen: true})}
                >
                    Open Lightbox
                </button>

                {isOpen &&
                <Lightbox
                    mainSrc={images[photoIndex]}
                    nextSrc={images[(photoIndex + 1) % images.length]}
                    prevSrc={images[(photoIndex + images.length - 1) % images.length]}

                    onCloseRequest={() => this.setState({isOpen: false})}
                    onMovePrevRequest={() => this.setState({
                        photoIndex: (photoIndex + images.length - 1) % images.length,
                    })}
                    onMoveNextRequest={() => this.setState({
                        photoIndex: (photoIndex + 1) % images.length,
                    })}
                />
                }
            </div>
        );
    }
}

from react-image-lightbox.

malroc avatar malroc commented on July 18, 2024 2

Same issue.
This is a known bug in react-modal: reactjs/react-modal#133
The workaround helped, but since react-image-lightbox relies on react-modal and calls it implicitly, it isn't just a "react-modal usage issue", it is a react-image-lightbox issue too.

from react-image-lightbox.

fritz-c avatar fritz-c commented on July 18, 2024

This sounds more like a react-modal usage issue, but could you provide some sample code anyway?

from react-image-lightbox.

itviventura avatar itviventura commented on July 18, 2024

Hi Fritz-c,

Do you know if is enough to work with var Lightbox = require('react-image-lightbox'); or is necessary to use create any instance of react-modal?

I have just the following code:

var Lightbox = require('react-image-lightbox');
var images = [
    'https://d2ji2mue1p384z.cloudfront.net/img/2048x1536/196854.jpg',
    'https://d2ji2mue1p384z.cloudfront.net/img/2048x1536/196856.jpg',
];

window.ImageLightboxCollage = React.createClass({
    getInitialState: function() {
        return {
            index: 0,
            isOpen: false
        };
    },
    openLightbox: function() {
        this.setState({ isOpen: true });
    },
    closeLightbox: function() {
        this.setState({ isOpen: false });
    },
    moveNext: function() {
        this.setState({ index: (this.state.index + 1) % images.length });
    },
    movePrev: function() {
        this.setState({ index: (this.state.index + images.length - 1) % images.length });
    },
    render: function() {
        var lightbox = '';
        if (this.state.isOpen) {
            lightbox = (
                <Lightbox
                    mainSrc={images[this.state.index]}
                    nextSrc={images[(this.state.index + 1) % images.length]}
                    prevSrc={images[(this.state.index + images.length - 1) % images.length]}

                    onCloseRequest={this.closeLightbox}
                    onMovePrevRequest={this.movePrev}
                    onMoveNextRequest={this.moveNext}
                />
            );
        }

        return (
            <div>
                <button type="button" onClick={this.openLightbox}>Open Lightbox</button>
                {lightbox}
            </div>
        );
    }
});


ReactDOM.render(React.createElement(ImageLightboxCollage, {params: params}), document.getElementById('main-header-container'));

Thanks a lot for you help

from react-image-lightbox.

fritz-c avatar fritz-c commented on July 18, 2024

Sorry for the delayed reply. Were you able to figure this out?

To answer your question, you don't need to add your own react-modal instance to use the lightbox. As far as I can tell from your code, it should be working.

from react-image-lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.