I was accidentally calling world.removeEntity and the

Calling destroy twice has very odd effects about ape-ecs HOT 1 CLOSED

JackStouffer commented on May 13, 2024

Calling destroy twice has very odd effects

from ape-ecs.

Comments (1)

fritzy commented on May 13, 2024

I wasn't able to reproduce this with a test.

ape-ecs/tests/index.ts

Lines 1918 to 1970 in 9dcbcd2

    
           it('#66 Calling destroy twice has very odd effects', () => { 
        
             const world = new World({ entityPool: 1 }); 
        
             class TestA extends Component { 
        
               static properties = { 
        
                 greeting: "Hi", 
        
                 a: 1 
        
               }; 
        
               static typeName = 'TestA'; 
        
               greeting: string; 
        
               a: number; 
        
             } 
        
             class TestB extends Component { 
        
               static properties = { 
        
                 greeting: "Hi", 
        
                 a: 1 
        
               }; 
        
               static typeName = 'TestB'; 
        
               greeting: string; 
        
               a: number; 
        
             } 
        
             world.registerComponent(TestA); 
        
             world.registerComponent(TestB); 
        
             const e = world.createEntity({ 
        
               c: { 
        
                 TestA: { 
        
                   greeting: "What", 
        
                   a: 2 
        
                 } 
        
               } 
        
             }); 
        
             world.removeEntity(e); 
        
             e.destroy(); 
        
             const e2 = world.createEntity({ 
        
               c: { 
        
                 TestB: { 
        
                   greeting: "No", 
        
                   a: 3 
        
                 } 
        
               } 
        
             }); 
        
             expect(e2.has('TestA')).to.be.false; 
        
             expect(e2.has('TestB')).to.be.true; 
        
           });

However, you're right, that destroy() should no-op the second time, so I made that fix (world.removeEntity(e) also calls destroy() on the entity).

Is there some other way that I can reproduce the problem in the previous commit reliably?

In any case, [email protected] has been published.

from ape-ecs.

Calling destroy twice has very odd effects about ape-ecs HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	it('#66 Calling destroy twice has very odd effects', () => {

	const world = new World({ entityPool: 1 });
	class TestA extends Component {

	static properties = {
	greeting: "Hi",
	a: 1
	};

	static typeName = 'TestA';
	greeting: string;
	a: number;
	}

	class TestB extends Component {

	static properties = {
	greeting: "Hi",
	a: 1
	};

	static typeName = 'TestB';
	greeting: string;
	a: number;
	}

	world.registerComponent(TestA);
	world.registerComponent(TestB);

	const e = world.createEntity({
	c: {
	TestA: {
	greeting: "What",
	a: 2
	}
	}
	});
	world.removeEntity(e);
	e.destroy();

	const e2 = world.createEntity({
	c: {
	TestB: {
	greeting: "No",
	a: 3
	}
	}
	});

	expect(e2.has('TestA')).to.be.false;
	expect(e2.has('TestB')).to.be.true;
	});