ZeroDivisionError on 4-level trees about tree-gen HOT 2 CLOSED

I think if length is 0 for a level then we should automatically stop generation of that level. We could just put a check within the generation process or we could check the parameters before generation as you suggest and reduce the value of levels to the correct number (i.e. the highest that won't include branches of length 0). Given that the end behaviour would be as expected (i.e. no branches at that level = branches of 0 length at the level), I think this is ok.

I'm not sure whether there are many parameter values that would result in crashes like this, and we'd have to hardcode the checks (whatever they may be) so I'm not sure it's worth implementing some big sanitisation system for all parameters at this stage. I would just put in a check for this specific case and leave it at that for now. Ideally I want to avoid restricting what parameters people can input as much as possible, so rather than getting errors they simply get the model they expect (like I describe above by just skipping the broken level) or stupid looking models causing them to choose better parameters.

from tree-gen.

from tree-gen.