Token type collision about twigcs HOT 5 CLOSED

Just gonna add some more info related to this.

Template as a reference point:

{% set foobar = foo|map(bar => baz) %}

Tried using the Official ruleset on this, the following was the result:

l.1 c.29 : ERROR There should be 1 space(s) before ">".

When I printed out tokens, the following was the result:

BLOCK_START_TYPE()
ARROW_TYPE( )
NAME_TYPE(set)
ARROW_TYPE( )
NAME_TYPE(foobar)
ARROW_TYPE( )
OPERATOR_TYPE(=)
ARROW_TYPE( )
NAME_TYPE(foo)
PUNCTUATION_TYPE(|)
NAME_TYPE(map)
PUNCTUATION_TYPE(()
NAME_TYPE(bar)
ARROW_TYPE( )
OPERATOR_TYPE(=)
OPERATOR_TYPE(>)
ARROW_TYPE( )
NAME_TYPE(baz)
PUNCTUATION_TYPE())
ARROW_TYPE( )
BLOCK_END_TYPE()

from twigcs.

I've also found out about #69 but I'm not sure whether that means versions older than 4 would not be getting the arrow token support?

from twigcs.

The easiest way to fix this would be to change the numbers of the custom tokens Twigcs introduces but it feels like it's just a workaround. This problem lies inside a greater problem I'm trying to figure out how to solve: keeping up with twig versions in a consistent way.

Nowadays I'm tempted to go with some opinionated choices:

• Stripping the Lexer from the official library, we copy it inside Twigcs and maintain it separately with our needed code (custom tokens, newlines handling): no more collisions, no more twig dependency inside composer, we gain full control on that.
• Killing twigcs 3.x as fast as possible (so many unfixable things like arrow functions)
• Adding Twig 1, 2 and 3 support inside twigcs 4.x before it is out of beta (using 3 rulesets ?)

from twigcs.

I've submitted a PR that will fix this issue here : #114.

from twigcs.

I'm closing this as the PR got merged!

from twigcs.