False positive when there is a ternary in an inline tag about twigcs HOT 6 CLOSED

Thank you! I reproduced the bug! I'll take a look at it.

from twigcs.

I forgot to mention that I'm running the commit 80d4f9a, the version v4.0-BETA3

from twigcs.

I'm not able to reproduce by only using {% block myblock 'foo' ~ (mycondition ? 'bar' : 'baz') %} in a template. Can you provide me a small snippet that triggers it if used as is?

from twigcs.

Here the exact code structure:

{% block block_name 'some-text' ~ (not a_function() ? ' other other-text-2') %}

from twigcs.

@OwlyCode do you have any news about this bug ?

from twigcs.

@stof It looks like it's a problem inside ScopedExpression where the parentheses are wrongly associated, resulting in a broken tree:

> ./bin/twigcs-debug reg:deb test.html.twig

Expr
====

{% block block_name 'some-text' ~ (not a_function() ? ' other other-text-2') %}

Sanitized expr
==============

{% block block_name 'AAAAAAAAA' ~ (not a_function() ? 'AAAAAAAAAAAAAAAAAAA') %}

Extracted node tree
===================

 ↪ {% block block_name 'AAAAAAAAA' ~ __PARENTHESES__ (offset: 0, type: expr)
     ↪ (not a_function__PARENTHESES__ ? 'AAAAAAAAAAAAAAAAAAA') %} (offset: 34, type: expr)
         ↪ () (offset: 49, type: expr)

But sadly I have not started working on the fix yet.

from twigcs.