Get the current OAuth client about fosoauthserverbundle HOT 12 CLOSED

Why doesn't https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/tree/feature/client-on-token merged to the master?

from fosoauthserverbundle.

Done :)

from fosoauthserverbundle.

Can I send a pull request?

from fosoauthserverbundle.

@pierre Why don't you "just" do this :

$token = $securityContext->getToken()->getToken();
$accessToken = $accessTokenManager->findTokenBy(array('token' => $token));
$client = $accessToken->getClient();

from fosoauthserverbundle.

It does 1 additional request in the database:

$accessToken = $accessTokenManager->findTokenBy(array('token' => $token));
Is useless if we set the client in FOS\OAuthServerBundle\Security\Authentication\Token\OAuthToken

from fosoauthserverbundle.

Yes, why not. I think it can be useful.

from fosoauthserverbundle.

Actually, we should store the access token (doctrine document/entity) as an object in the oauth security token.
Currently, it's a string.

from fosoauthserverbundle.

I agree, storing this info on the token entity sounds more efficient.
cc: @willdurand what do you think?

I can work on PR if you think its relevant

from fosoauthserverbundle.

There's a branch in the bundle, there's #188, why hasn't this been merged yet? /cc @GuilhemN

from fosoauthserverbundle.

Sorry I don't have the time to review this bundle's PRs anymore... But I can add you as collaborator if you're willing to maintain this bundle.

from fosoauthserverbundle.

I'll do my best, let's do it. 👍

from fosoauthserverbundle.

Thinking about this, we shouldn't set the client, instead we should inject the whole token instead of only the string. Will work on this for 2.0.

from fosoauthserverbundle.