Code Monkey home page Code Monkey logo

Comments (6)

stof avatar stof commented on August 17, 2024 1

This does not need to go in a v2. It is not a BC break, and so could go in a 1.x release (it is part of having proper Symfony 4 support)

from fosckeditorbundle.

ElectricMaxxx avatar ElectricMaxxx commented on August 17, 2024

we currently support symfony/lte:2.* which means we would have to use duplicated code or some conditions to use features from Symfony 3.4 and above. We should talk about dropping SF-2 support on 2.0 of this bundle, which can possibly be the next :-)

from fosckeditorbundle.

stof avatar stof commented on August 17, 2024

well, the only thing you would have to duplicate is the command name, to have it both in configure and in the externally-accessible location (and if you go for the static property rather than the tag attribute, you can even remove this duplication by reading the property).

from fosckeditorbundle.

stof avatar stof commented on August 17, 2024

Symfony 3.3 and older would not know how to read the tag attribute containing the name or the static property, but they will not complain about them.

from fosckeditorbundle.

enekochan avatar enekochan commented on August 17, 2024

The static property name is $defaultName

from fosckeditorbundle.

fbourigault avatar fbourigault commented on August 17, 2024

I have a preference to use the DI tag attribute over the static property name because it's all about dependency-injection.

from fosckeditorbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.