Comments (6)
This does not need to go in a v2. It is not a BC break, and so could go in a 1.x release (it is part of having proper Symfony 4 support)
from fosckeditorbundle.
we currently support symfony/lte:2.* which means we would have to use duplicated code or some conditions to use features from Symfony 3.4 and above. We should talk about dropping SF-2 support on 2.0 of this bundle, which can possibly be the next :-)
from fosckeditorbundle.
well, the only thing you would have to duplicate is the command name, to have it both in configure
and in the externally-accessible location (and if you go for the static property rather than the tag attribute, you can even remove this duplication by reading the property).
from fosckeditorbundle.
Symfony 3.3 and older would not know how to read the tag attribute containing the name or the static property, but they will not complain about them.
from fosckeditorbundle.
The static property name is $defaultName
from fosckeditorbundle.
I have a preference to use the DI tag attribute over the static property name because it's all about dependency-injection.
from fosckeditorbundle.
Related Issues (20)
- replace travis-ci badges in the README
- [Doc] The "Contributing" section of doc index is empty HOT 1
- There are no commands defined in the "ckeditor" namespace HOT 2
- An exception has been thrown during the rendering of a template HOT 1
- Bump php version? HOT 2
- CkEditor not working on Heroku with PHP stack HOT 1
- [doc] Impossible to load asynchronously
- Symfony 6 compatibility HOT 1
- Cannot paste base64 if filebrowserUploadHandler is set
- Ckeditor 5 ? HOT 11
- About installing with npm
- Installer fails when proxy requires authentication HOT 1
- When adding additional config i get a JS code but it does work
- "Error code: exportpdf-no-token-url" or how we can remove plugin via configuration? HOT 1
- code snippet is non-existent HOT 2
- Error invalid-lts-license-key HOT 39
- [RFC] Deprecate the bundle? HOT 4
- Custom install
- Will there be Symfony 7 support? HOT 3
- Support for Symfony 7 HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fosckeditorbundle.