Code Monkey home page Code Monkey logo

Comments (4)

EngineerPehr avatar EngineerPehr commented on May 25, 2024

I'm new to open source, and I would love to take a crack at this issue. I have been working with Javascript for about 3 years.

from ancientbeast.

DreadKnight avatar DreadKnight commented on May 25, 2024

@EngineerPehr Heya! Alright, assigning you to it. 2 weeks soft deadline 🐻

from ancientbeast.

EngineerPehr avatar EngineerPehr commented on May 25, 2024

@DreadKnight
I was able to fix this by changing the animation speed. However, based on feedback from some friends I had play the game with me, I think it might be worth changing the text of the "no_actions" tooltip to something like "Out of Actions" and "End Turn". Do you want me to do that before creating a pull request?

from ancientbeast.

DreadKnight avatar DreadKnight commented on May 25, 2024

@DreadKnight I was able to fix this by changing the animation speed. However, based on feedback from some friends I had play the game with me, I think it might be worth changing the text of the "no_actions" tooltip to something like "Out of Actions" and "End Turn". Do you want me to do that before creating a pull request?

@EngineerPehr In Ancient Beast, "End Turn" is "Skip Turn", due to us using hotkeys focused on QUERTY type of keyboard.
Pressing "S" => skips the turn. Text is ok, as it's enforcing the consistency of the action. Feel free to make PR for the fix 👍🏻

from ancientbeast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.