Code Monkey home page Code Monkey logo

Comments (4)

RichardBarry avatar RichardBarry commented on June 7, 2024

portBASE_TYPE is a legacy definition that was deprecated many many years ago in favour of BaseType_t - so the two should be the same - the fact they are not may be a quirk of this being an 8-bit part and whether a char defaults to signed or unsigned differs between compilers and even the options passed to the compiler.

Both the Cygnal port and demo are also very old and have been listed on the 'known issues' list for long time as we don't prioritise updating it. So you have the double issue of the demo also referencing legacy 'common' demo files in the FreeRTOS/Demo/Common/Full directory which were not updated to use BaseType_t.

To sort this for you I think the first thing to do is update your build to reference files in the FreeRTOS/Demo/Common/Minimal instead of the FreeRTOS/Demo/Common/Full directory, and search and replace use of portBASE_TYPE to BaseType_t within the files local to the demo itself (files like main.c) - then you will be using types and files that are not deprecated and any issues you are still facing after that we can fix in the main line - so please report back.

[edit]Also at that point it would be great to get your changes to the demo c and makefile upstreamed too so others don't have the same issue[/edit]

from freertos.

spth avatar spth commented on June 7, 2024

If deprecated years ago, why is Common/include/serial.h still using portBASE_TYPE? Or is that file deprecated too?

from freertos.

spth avatar spth commented on June 7, 2024

I am no really familiar with FreeRTOS or Cygnal devices. I don't even have one.
I just had a quick look at the port out of curiosity. However, I am somewhat familiar with C and SDCC. The attached patch is sufficient to make the Cygnal port compile with current SDCC (i.e. revision 11556 or later - an SDCC bug making FreeRTOS compilation fail was fixed just today).

However, it does not link yet (the Makefile expects a few object files in different directories from where they are built), and of course I did no testing.
sdcc-current.patch.gz

from freertos.

muneebahmed10 avatar muneebahmed10 commented on June 7, 2024

The return type of xAreSemaphoreTasksStillRunning in FreeRTOS/Demo/Common/Full/semtest.c appears to have been updated to BaseType_t in #159:

BaseType_t xAreSemaphoreTasksStillRunning( void )

As this is the same type used in FreeRTOS/Demo/Common/include/semtest.h, it looks like the bug is no longer present, so I will close this issue. Please open a new issue if you encounter any further difficulties.

Thank you

from freertos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.