Code Monkey home page Code Monkey logo

Comments (1)

apyrgio avatar apyrgio commented on August 13, 2024 1

That's an interesting case. We can't move the file the symlink points to, since another symlink may point to that as well. On the other hand, it doesn't make sense to move just the symlink, as this is brittle (as you correctly pointed out).

What we should probably do here is:

  1. Resolve the symlink, and find the original file.
  2. Copy (but not move) the original file under unsafe/
  3. Remove the symlink.

This way, it's less easy for the user to accidentally click on the original file (that's the spirit of the archiving feature), and we are sure that they can recover the original file from the unsafe/ directory, even if they move stuff around (also very important).

from dangerzone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.