Code duplicity in " Learn Modern JavaScript Methods by Building Football Team Cards" lesson in "JavaScript Algorithms and Data Structures" course about freecodecamp HOT 3 CLOSED

I would suggest deleting the information from the HTML page (have an empty #player-cards div), and call the setPlayerCards function after it's definition (as in the code below (copied the relevant part))

Yeah, this would involve add on extra step, and removing the HTML from the seed code which wouldn't be that much to change.

I would be more on board with this change then fetching the data from elsewhere.

But let's hear from the rest of the team to see what they think.

from freecodecamp.

Ideally we'd have the hardcoded information outside of the code in an external file or server, but that's not been taught yet at this stage

Yeah, I don't think we should update the project to move the data elsewhere only to have campers use fetch to access that data.

Fetch isn't taught until the last two projects. I think it would be best to leave it as is.

from freecodecamp.

Ideally we'd have the hardcoded information outside of the code in an external file or server, but that's not been taught yet at this stage

Yeah, I don't think we should update the project to move the data elsewhere only to have campers use fetch to access that data.

Fetch isn't taught until the last two projects. I think it would be best to leave it as is.

I agree :)
Was mentioning it as a general point. I of course think it's for a later point of the course to work in this way

from freecodecamp.