Code Monkey home page Code Monkey logo

Comments (57)

bernhard-hofmann avatar bernhard-hofmann commented on July 27, 2024 14

I'd suggest allowing authentication via Google, Facebook, Twitter, etc.

An important aspect of this from a user's perspective is to allow a single user account to be associated with multiple social/oauth accounts. (Both my Google and my Twitter accounts are still just me.)

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 6

Proposed PR template that closely mirrors the main curricula:

  • You have read the contribution guidelines
  • Your pull request uses a descriptive title (not a vague title like update.md)
  • Your pull request targets the master branch of chapter
  • Closes #XXXXX

Proposed issue template that closely mirrors the main curricula:

  • Is your feature request related to a problem? Please describe.
    A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
    • Describe the solution you'd like
      A clear and concise description of what you want to happen.

    • Describe alternatives you've considered
      A clear and concise description of any alternative solutions or features you've considered.

    • Additional context
      Add any other context or screenshots about the feature request here.

from chapter.

allella avatar allella commented on July 27, 2024 6

@chrismgonzalez and others, Quincy gave a handful of folks write permission to Github and there are a handful of Discord moderators.

I think it would be handy to list these folks somewhere we can link to in one place. Thoughts on adding to the README, or perhaps better to add a Quick Link on the readme and link to a new page/issue.

Github Write Permissions
@bernhard-hofmann
@kognise
@dmmulroy
@francocorreasosa
@vaibhavsingh97
@abbott
@erictleung

Discord Moderators
These are Discord usernames and not necessarily Github usernames.
@ pixely#7774
@ sarvottam#4454
@ dharavihol#8588
@ QuincyLarson#8146
@ vkWeb#0291
@allella

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 3

@allella I would like to propose that we maintain parity with the main FCC repo in terms of tag patterns. The consistency would be very helpful and unifying.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 2

Eventbrite API docs
Meetup API docs

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024 2

@chrismgonzalez It feels like you are very excited about the docs thing. Then you should lead our efforts for documentation ;)

Right @allella? 😄

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 2

@vkWeb I understand your concern and I would like to go with your label system in the future. Could we keep it pinned for now since it is the central hope for all documentation as of this point in time?

I don't mind leading doc efforts. I feel like that is my strength until I understand the tech stack better and can contributing to the code.

Feel free to message me in Discord if you want to talk about it further.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 1

I'd suggest allowing authentication via Google, Facebook, Twitter, etc.

An important aspect of this from a user's perspective is to allow a single user account to be associated with multiple social/oauth accounts. (Both my Google and my Twitter accounts are still just me.)

How about this:

  • Account & Notifications
    • Accessing an account
      • Social logins/SSO - Github, Facebook, Twitter, Gmail, etc

from chapter.

namvnngu avatar namvnngu commented on July 27, 2024 1

In “Using Chapter”, in my humble opinion, we can create a small code competition in small groups/events to encourage users to not only study and increase their interactivity. Through the competition, they can achieve point/award to level up their position in groups, but we need to maintain their equality. Again, competition is just a small feature/playground for everybody to learn each other, but not a main point in Chapter.

from chapter.

allella avatar allella commented on July 27, 2024 1

Looks like FCC uses tags more than title patterns so maybe that's the way to go.

from chapter.

mojo706 avatar mojo706 commented on July 27, 2024 1

Hi for the contributors guide, I really always find this helpful as a link Working With Forks could this be added to the Contribution Guidelines? If it helps I can summarise it.

from chapter.

mojo706 avatar mojo706 commented on July 27, 2024 1

The owner of the channel is the one who would do that. It's really easy, on the settings.

from chapter.

mojo706 avatar mojo706 commented on July 27, 2024 1

So you click the dropdown next to the Channel Name, then you click on Server Settings
Screenshot 2019-10-16 at 17 41 22

Then click on roles and create the roles.
Screenshot 2019-10-16 at 17 45 12

Then there is a plus button that helps you create new roles 😌
Screenshot 2019-10-16 at 17 47 51

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 1

Yes, we'll need to wait and see how the branding plays out -- which is totally good. As I look on the Gatsby site showcase, it looks like FCC knowledge base that is linked to from the curriculum is a Gatsby site. This furthermore solidifies my initial thoughts of deploying the docs site (when we get to that point) as a Gatsby site.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024 1

@allella I will take a look. I'm on break from work all this week so I will have some time to sit down and work on some stuff. Thanks for keeping everything lined up around here!

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Made edits to the above DOCS outline

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez have you any suggestions for format of issue titles? It seems someone started out with a pattern on the features and we've gone all over the place since then.

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez I've not worked on a project with enough issues for it to matter, but I could imagine people posting Tasks, Research, Question, Ideas that may fall outside of the coding or implementation side. So, do we want those "other" things in the issue queue?

from chapter.

allella avatar allella commented on July 27, 2024

I'm involved in local projects and not in tune with Free Code Camp's system and systems. Is there anybody here besides @QuincyLarson who's coming over from FCC's Github and has suggestions for what might work so we're not re-inventing everything on every aspect of managing the project?

from chapter.

allella avatar allella commented on July 27, 2024

Yeah, looking at the other FCC repos shows there's a lot to be borrowed. Though, some of it may be overkill until the project get's large.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Agreed, let’s keep it down to just what we need for now.

from chapter.

allella avatar allella commented on July 27, 2024

For instance, is MODERATORS.md a convention. Or, is there already an easy way to see this in Github and Discord?

Best I can find is people in Discord have a green username and the Insights page shows people who have committed, but not necessarily have write or more than basic access.
https://github.com/freeCodeCamp/chapter/graphs/contributors

from chapter.

mojo706 avatar mojo706 commented on July 27, 2024

On discord you can add roles as a separate group such as mods. Then they will have a section on the right sidebar

from chapter.

allella avatar allella commented on July 27, 2024

On discord you can add roles as a separate group such as mods. Then they will have a section on the right sidebar

So, that's a Discord setting someone would need to change and then everybody would see that in the sidebar? Or, is it a per-person setting?

from chapter.

allella avatar allella commented on July 27, 2024

The owner of the channel is the one who would do that. It's really easy, on the settings.

I'll have to ask Quincy to do it. You have a screenshot or link that I can share with him? He's a busy dude, and I can't see the admin settings to map it out.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

@allella I don’t mind having write perms if you guys are ok with it. I may have gone to bed before all of you decided that. If not, that’s fine, too.

We could add a table in the contributing guide and readme listing moderators/POCs. If there is someone that has a specific specialty, perhaps it would be wise to list them as a POC for a specific topic (front end, back end, Docs, etc.)

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez yes, Quincy thought it would be a good idea if I surveyed the issue queues to see who's helping a lot and identify topical POCs. He did a bit of by granting write via pull requests, so there will likely be some overlap. Still, I think it's good to associate folks with what they are focused on so we have some "quick people" and "quick links" to lower friction.

I also asked him to give you write permissions since you're heading up the docs.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Sounds good to me! I don't plan on approving PR's unless they deal with docs. Additionally, It would be good to get more than just 1 set of eyes on everything before it gets merged in.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Hi for the contributors guide, I really always find this helpful as a link Working With Forks could this be added to the Contribution Guidelines? If it helps I can summarise it.

@mojo706 Would you mind submitting a PR draft of what you propose in the quote above? Please reference this issue (but don't mark it for closing). I find myself referencing this information on a regular basis, it would be nice to have it included in the repo. This repo is changing rapidly so we need to make sure local forks are kept up to date as best as we can.

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez I see from #66 that Github has a SUPPORT.md suggestion.

Maybe that's the place to list POC/moderators, people with write/merge, Discord moderators?

from chapter.

mojo706 avatar mojo706 commented on July 27, 2024

@chrismgonzalez I think someone else already did this, so it's cool

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez shall we add a link on the CONTRIBUTE.md to the Github project moderators?

Maybe under Step 4, or the very bottom of the page?

I don't know if the project moderator page is public, but if it is then linking to it is likely better than listing people's names. The list is likely to change in the early going.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

I want to tell you all that we should not put GitHub mods or discord moderator names on the documentation now. If a contributor runs into any problem then he or she should be directed to the discord server for help.

We can add names of mods (long term mods) later in the project with their email.

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez also, we have some PR templates committed and we can update your outline above and possibly link to them, if that's helpful for people. Maybe link that bullet to https://github.com/freeCodeCamp/chapter/tree/master/.github ?

from chapter.

allella avatar allella commented on July 27, 2024

@vkWeb alright. Figured it would be something people are going to ask, but sounds like you're speaking from bad experiences.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

@chrismgonzalez also, we have some PR templates committed and we can update your outline above and possibly link to them, if that's helpful for people. Maybe link that bullet to https://github.com/freeCodeCamp/chapter/tree/master/.github ?

No need to do that. My docs PR which you merged will automatically put a template for contributors when they create a PR.

@vkWeb alright. Figured it would be something people are going to ask, but sounds like you're speaking from bad experiences.

Not exactly bad experiences 😅. See, people want immediate help or they will pass by. Through discord, they'll get help in at most an hour.

from chapter.

allella avatar allella commented on July 27, 2024

K. I linked to the templates above more to show progress, so no harm either way.

That moderators page may not be public anyway, so nothing to do there for now too.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

@allella Yes.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

I'm just now getting in to see all these comments. Thanks for editing to main issue body above! At these early stages of development it may be worth considering that we should link to the Discord in the README or contributing guide like @vkWeb is suggesting.

shall we add a link on the CONTRIBUTE.md to the Github project moderators?

Maybe under Step 4, or the very bottom of the page?

I don't know if the project moderator page is public, but if it is then linking to it is likely better than listing people's names. The list is likely to change in the early going.

I would feel more comfortable adding this in once we are a little farther along in the development and a core team/regular contributors are decided upon. Feel free to disagree and chat about it if you would like. I think our moderator group is OK for now. It seems like approval and merging of PR's is speeding up since Quincy has assigned more permissions.

At some point this weekend I plan to update the doc outline. We can go ahead and start authoring API docs since the Swagger API is built out. I would like to entertain your thoughts on the best method of doing this. Obviously we can use the existing /docs folder in the repo, fill that with folders by category, and place in .md files. I would then like to get a docs site up and running.

Speaking of a docs site - does anyone have ideas of going about doing this? I'm thinking a subdomain like docs.chapter.org or something of the like. My first thought is doing a Gatsby site that can pull the data in from the .md files. Opinions?

from chapter.

allella avatar allella commented on July 27, 2024

I have no experience with doc sites, just wrangling people, so I'd defer to tools people find easy to use.

Regarding a docs site, this brings up the question if/when @QuincyLarson would buy a new domain, since chapter.org is obviously taken.

My guess is he's planning to start with a chapter.freecodecamp.org for the "dogfooding", but by the time it goes beyond FCC's use cases then things would be under a dedicated domain.

If a new domain is used, then obviously we'd want to avoid publicly disclosing the domain before it's secured so some squatter doesn't buy the domain.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Yes, I can see the issues with that. So for now - just put documentation in the docs folder as a temporary storage spot. We can sort out implementation later. Once the API is more firmly set in stone, let's start work on those docs. The EventBrite docs are a good model here.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

Initially, in the dogfooding period, we should keep API docs on the repo as .md files inside /docs folder as @chrismgonzalez mentioned and then later at some point we can use GitHub pages. It's free & simple to set up.

What do you think @allella @chrismgonzalez?

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

Yes, @vkWeb those are my initial thoughts, and I've already created some folders in a PR merge last night. I'm going to let the API get more finalized for this initial release before constructing docs.

My later vision is to create a docs site that is similar to the Gatsby docs

Looks like we have a structure in place. I'm going to pin this issue just so it doesn't get buried as more issues get submitted.

from chapter.

allella avatar allella commented on July 27, 2024

I trust Chris on this as he's got a vision for the docs. I'm most comfortable organizing and reducing friction on the conversations by connecting people to people, and people to issues/PRs.

Still this triggered the question of if Quincy plans to brand this under FCC using subdomains for everything, which seems like it would get confusing, or eventually having a branded web domain for the broader Chapter brand.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

My later vision is to create a docs site that is similar to the Gatsby docs
Looks like we have a structure in place. I'm going to pin this issue just so it doesn't get buried as more issues get submitted.

Yes, we can think of Gatsby. We'll confirm this at a later point.

@chrismgonzalez Instead of pinning, please label it as api doc or something similar. We can always sort issues by labels. We should only pin issues that need to be exposed to all users. It is helpful in cases when a bug is observed in production, to clarify confusions or to ask for help from contributors. :)

from chapter.

andyst81 avatar andyst81 commented on July 27, 2024

I'm really interested in helping out on this project, but feel that there are a lot of more capable programmers here already, so would be happy to contribute to the docs. I'm quite familiar with Gatsby too and enjoy working with it, so would be happy to do that, if that's the direction here.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

@chrismgonzalez You raise a valid point. Let's keep it pinned for now. Sure, I'll DM you regarding the docs planning & set up when time comes :)

@andyst81 Welcome! No, it isn't like that 😅. We all are learning. Many are beginners including me. Feel free to contribute to docs section if you are happy with it. Every issue/PR helps us :)

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

@andyst81 Welcome. You're help will be needed. I can't do all of it myself. Your contributions are more than welcome, even if you think they are small!

from chapter.

gideonpraise avatar gideonpraise commented on July 27, 2024

A quick question please, (forgive me if this the wrong place to ask)...

Is there room for someone that is not a user to opt-in as a sponsor for an event?

from chapter.

allella avatar allella commented on July 27, 2024

@gideonpraise thanks for your suggestion. There are two issues open, #83 and #84, to share suggestions in the format of a "user story". I'm not sure the suggestion will be necessary for the initial MVP build, but you're welcome to post on #84 so we have it in a memorable place in the issues.

from chapter.

gideonpraise avatar gideonpraise commented on July 27, 2024

@allella Okay thanks. I will do just that

from chapter.

QuincyLarson avatar QuincyLarson commented on July 27, 2024

@chrismgonzalez Thank you for putting together this excellent list of starting documents.

I just created a GitHub Wiki for us to start with (we can later migrate these articles elsewhere, but this is a convenient place to begin).

I'm looking for a volunteer who can create each of these articles and a few paragraphs for each addressing its topic.

from chapter.

vkWeb avatar vkWeb commented on July 27, 2024

@chrismgonzalez I have updated the issue and added "help wanted" label to allow contributors to work on this. The documentation will be under your supervision.

Right now we can only work on API documentation as we are still implementing features for MVP. Once we have all the features down we can start writing documentation for accounts, members, organizers, etc.

from chapter.

allella avatar allella commented on July 27, 2024

@chrismgonzalez I wanted to ask if you'd still have time and interest to stub out the docs in the Wiki, as Quincy requested in #47. Or, at least help us pull together a group and give the task some direction.

(I created our GitHub wiki to serve as the initial home for our documentation, but we need a volunteer to create these individual articles) - Quincy

You did a nice job moving things forward on the initial repo docs and that's sort of what we need on this stubbing phase. We obviously don't have an app to document, but Quincy suggested stubbing out the structure as another way to make everyone think about how users will interact with the app.

I'm better at things once there's more definition and feel I can help review new docs and put meat on the bones. However, I'm less enthusiastic about my ability to quickly create a docs skeleton without spending way too much time spinning wheels in the abstract.

For instance, I'm not even sure what best practices I'd follow. Organize docs by role? By section of the site? By user stories? etc.

Hoping you can help move this along and/or pull in more folks. For instance, we had a handful of offers to help with docs from #11, including @lcarbonaro @chipironcin @xarielx
and some others we can ping in Discord.

from chapter.

QuincyLarson avatar QuincyLarson commented on July 27, 2024

@chrismgonzalez I've broken this issue out into separate issues and put them in our documentation column on our project board: https://github.com/freeCodeCamp/chapter/projects/1

Also note that our API documentation is created programmatically. @Zeko369 proposed us using a procedurally generated GitHub page that gets updated when people merge new code.

from chapter.

chrismgonzalez avatar chrismgonzalez commented on July 27, 2024

That’s great! Will check it out this evening after the kiddo is in bed. Thanks for your help on this, sorry I’ve been absent for a bit.

from chapter.

QuincyLarson avatar QuincyLarson commented on July 27, 2024

@chrismgonzalez No worries. It's the holidays so I'm glad you're spending time with your kids. We are working to break all of this down to smaller bits so each contributor can grab more bite-sized chunks of work, and PRs can be more atomic :)

from chapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.