atf-c/macros/use: fails with clang -Wunused on FreeBSD head about atf HOT 2 CLOSED

Confirmed that it's still occurring with handrolled copy of atf via bd96595.

from atf.

Oh wow, I wonder how this went unnoticed for so long. Seems a legitimate problem with the tests but I haven't tried to reproduce yet. Bleh, different warning diagnostics across different compilers.

Adding __attribute__((__unused__)) is going to be tricky because the code triggering the problem comes from within macros.

The easiest way out, I think, would be to actually put the unused variables to use by referencing them. Doing something like:

atf_tc_pack_t *test_pack_1 = ATF_TC_PACK_NAME(TEST_MACRO_1)

should do the trick. The trick is to not make pack1 static so that the compiler can't tell it's not being used (just as we do with test_name_1).

from atf.