Code Monkey home page Code Monkey logo

Comments (12)

FredJul avatar FredJul commented on May 18, 2024

You're right, this is something I should add so I accept this request, at least to thanks the translators and contributors. Nevertheless I seriously lack of free times currently, I won't be able to do it soon.

from flym.

strubul avatar strubul commented on May 18, 2024

Hi HoloAddict,
I would like to contribute and I was trying to add the button about at the Bar. But I think I met some issues with the title...

The main issue is that a big custom title such as "Times - World" gets truncated in the currently published version. And maybe this is a problem if you have multiple prefixes starting with "Times". For example:

default

I tried to add an about button but then the main title "Entries" gets truncated:

aboutbutton

One way to fix this is to split the bar when there is no much space and place them at the bottom:

splitnarrow

What is your opinion on these? If you have a short "about" text I would be able to make a pull request!

from flym.

FredJul avatar FredJul commented on May 18, 2024

Hi!

In fact I don't really want to split the action bar due to the drawer. When you open the navigation drawer, you expect the option to be visible into the top action bar. If you look well, even Google do not use much the splited action bar...

And I also do not want to add more than 3 items into the action bar, due to the lack of place. I think a good solution would be to put a "about us" link into the settings screen. It's a bit hidden but this is not a important UI part and Google is also doing this into android settings.

Of course I would be happy to include your work ;) I will send an email to all people which participate to put their name/nickname/email or what they want in it.

from flym.

FredJul avatar FredJul commented on May 18, 2024

Or maybe hide the refresh button (I think it's the less used one due to the automatic update) and add the menu overflow with options inside like "refresh", "edit feeds", "about us" and "parameters".

In fact I think some people won't like the disappearance of the refresh button but it may be the best solution. Some people also told me that the "edit feeds" option is hard to find, this would solve this issue in the same time.

from flym.

strubul avatar strubul commented on May 18, 2024

Yeap I think you are right..Maybe something like that (though I am not sure about the appropriate icons):

overflow

from flym.

ildar avatar ildar commented on May 18, 2024

16.01.2014 7:54 ÐÏÌØÚÏ×ÁÔÅÌØ "HoloAddict" [email protected]
ÎÁÐÉÓÁÌ:

Or maybe hide the refresh button (I think it's the less used one due to
the automatic update) and add the menu overflow with options inside like
"refresh", "edit feeds", "about us" and "parameters".

Actually the FeedEx UI is balanced quite well except...

Some people also told me that the "edit feeds" option is hard to find,
this would solve this issue in the same time.
True.
Please change carefully. Thanks!

from flym.

FredJul avatar FredJul commented on May 18, 2024

I found the screenshot quite nice ;) In fact I think you're right. It's better to hide the "mark all as read" button to avoid to click on it accidentally, even if I use it more than the refresh button.

Are you agree with that ildar?

from flym.

ildar avatar ildar commented on May 18, 2024

Double yes! ;-)

from flym.

mhuhtala avatar mhuhtala commented on May 18, 2024

I actually use the 'refresh' button all the time, and I, too, initially had trouble finding the 'edit feeds' button, so I think the layout in strubul's picture is an improvement. Also, when viewing the entries of one single feed, there 'edit' menu option could be present and it could take the user to edit that feed's settings directly. I can take a stab at implementing this.

from flym.

mhuhtala avatar mhuhtala commented on May 18, 2024

I implemented a simple 'about' screen and put the option to open it as the first thing in the settings (GeneralPrefsActivity). The 'about' activity currently shows the programmatically fetched version number (versionName) of the app, a copyright notice and some license information. There's a TextView for listing the volunteer contributors. I left it as a placeholder for now.

The menus in the list views in my version are as follows:

Drawer:

  • hide read (ActionBar)
  • refresh (ActionBar)
  • edit feeds (overflow menu)
  • settings (overflow menu)

Entries list:

  • hide read (ActionBar)
  • refresh (ActionBar)
  • mark all as read (overflow menu)
  • edit feeds (overflow menu)
  • settings (overflow menu)

I made the label on the 'edit feeds' option say 'feeds' explicitly, instead of just edit. I thought it was a lot clearer that way. When viewing the entries of a single feed, the option changes to "edit feed" (singular) and it takes the user directly to edit the configuration of that feed, not the list of all feeds.

The 'starred' and 'search' views have no overflow menus at all and only two options each in the ActionBar (same as before).

from flym.

mhuhtala avatar mhuhtala commented on May 18, 2024

Some screenshots (sorry about the size, I can't be asked to scale these).

Settings

About

Menu in entries list

from flym.

FredJul avatar FredJul commented on May 18, 2024

This is merged so I mark it as closed (even if I need to add all the contributors names)

from flym.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.