Rules should be combined by logical OR about feathers-casl HOT 5 CLOSED

released as v0.5.0

from feathers-casl.

Please fork the repo, do the changes to your fork and make a PR with the new test.
Would you please also add a test with:

    can("read", "tests", {
      $or: [
        { published: true }
        { user_id: { $in: [1] } },
      ]
    });
}

I know Casl states out, that this is not possible, but I would like to see the outcome.

I see that you're not using rulesToQuery or other helpers that CASL provides for this kind of thing. Is there a reason for that?
As stated on slack before, the following will not work properly with rulesToQuery:

rule: can('find', 'posts', { id: { $in: [1, 2, 3] } })
query: service('posts').find({ query: { id: { $in: [1, 2] } } } );

Expected:
finds 2 items with ids 1 and 2

Actually:
finds 3 items with ids 1, 2 and 3

from feathers-casl.

The problem with rulesToQuery is, that not all adapters support $not, $and and $nor (toMongoQuery).
I've started a new branch: https://github.com/fratzinger/feathers-casl/tree/multiple-adapters to test against most of the popular adapters.

from feathers-casl.

Please have a look at: https://github.com/fratzinger/feathers-casl/tree/logical-or that consequently integrates the $or logical

from feathers-casl.

I consider this ready now for v0.5.0 but I need some investigations. Stay tuned.

from feathers-casl.