Code Monkey home page Code Monkey logo

Comments (1)

ankush avatar ankush commented on September 26, 2024 3

Slightly modified proposal:

  • Leave old doctypes as is, introduce new doctype Extension Scripts or just Extensions (naming can be dealt with later)
  • Script types based on folder structure
- /scripts
    - /doctype_events
        - Sales Order.py (all events moved inside single file like controllers)
    - /api
        - path.py
    - /cron
        - crontab (cron -> file.py) 
        - script.py

Execution:

  • Use exec directly instead of safe_exec i.e. allow everything.
  • Not allowed in shared environment (same as current server script v15)
  • Provide a flag for using old syntax OR write a code-rewriter for old script to migrate to normal python syntax instead of safe_exec ones (quite hard IMO)
  • Once this is ready and we are confident about it, migrate server script contents to file and disable old doctype.

Pros:

  • better security model
  • version controllable
  • full access to vanilla python, libraries, imports

Cons:

  • Without a UI editor this can be quite a pain for users to edit using SSH. This can be solved by FC. For Frappe docker we can provide VS Code container with some control over who can access it. ( @revant 👀 )
  • Allowing full python also means allowing monkey patching using this, which eventually bigbraindevs will do. 🌚
  • breaking & migration woes

from frappe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.