Code Monkey home page Code Monkey logo

Comments (2)

cogk avatar cogk commented on September 25, 2024 2

I like this idea, and I'm fine with it. However, I believe it would be better to use a random ID for users (in general).

Pros: (all the usual arguments of random IDs)

  • it might avoid bottlenecks in distributed setups: random id = ~guaranteed to be available
  • reduce user ID contention and obsolescence: Why am I ankush12? Are there 11 other with the same name?
  • don't require migration from old system: varchar -> varchar (but it could be nice)
  • it might be beneficial in the case of data leaks (weak argument)

Cons:

  • require front-end to make requests everytime it needs to display a user, but i believe this is already the case, and would still be the case with ankush as ID
  • possibly more difficult to debug

We should consider migrating the existing IDs: old code could still work if name as email is still allowed, we want it to obviously break, in order to avoid problems down the line

from frappe.

HUMENTH avatar HUMENTH commented on September 25, 2024

@ankush
If there are users such as
[email protected],
[email protected], and
[email protected],
Frappe will determine which user ID to consider?

from frappe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.