Comments (2)
I like this idea, and I'm fine with it. However, I believe it would be better to use a random ID for users (in general).
Pros: (all the usual arguments of random IDs)
- it might avoid bottlenecks in distributed setups: random id = ~guaranteed to be available
- reduce user ID contention and obsolescence: Why am I
ankush12
? Are there 11 other with the same name? - don't require migration from old system: varchar -> varchar (but it could be nice)
- it might be beneficial in the case of data leaks (weak argument)
Cons:
- require front-end to make requests everytime it needs to display a user, but i believe this is already the case, and would still be the case with
ankush
as ID - possibly more difficult to debug
We should consider migrating the existing IDs: old code could still work if name as email is still allowed, we want it to obviously break, in order to avoid problems down the line
from frappe.
@ankush
If there are users such as
[email protected],
[email protected], and
[email protected],
Frappe will determine which user ID to consider?
from frappe.
Related Issues (20)
- bug(frappe.get_meta): if there is no existing doctype yet most of the function fails
- Renaming a doc doesn't reflect correctly in doctype python file HOT 1
- Shared and Unshared logs are not displayed in the Timeline (Activity log)
- Cannot access custom app through sidebar HOT 2
- Error in rename doc own user (User) V-15
- Nested translations not extracted to POT file from JavaScript files
- Add migration patch for new UTM analytics nomenclature? HOT 2
- remove_multiple not available in version-15 HOT 3
- doc should not be visible in list view when user permission applied on child table's item HOT 1
- on login, throws error "{workspace} not found" if a user does not has access to workspace
- In ListView, filters are not getting auto populated from Session defaults HOT 1
- Role Settings Permissions not working HOT 1
- Users with read-only permissions unable to approve workflow actions
- Issue on Cancellation of Employee Advances Linked with Non-Cancelable Payment Ledger Entries on ERPNext v15
- Allow renaming a document in the background
- Error on payment reconciliation
- Blank page when clicking on the apps menu
- Uploading a user profile picture in User detail page do not update profile picture in contact page
- Download excel shows incorrect total row count HOT 2
- Listview: disabled field overrides indicator
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frappe.