Customisation sync_on_migrate either does an exact sync or nothing at all about frappe HOT 7 OPEN

@mohsinalimat you're mostly running into this issue only. Perms exported via "Export customization" are forcefully synced.

from frappe.

What is the point of exporting a customisation if sync_on_migrate is not set?

Sync on install, but never again. It's useful in a lot of cases too.

from frappe.

What is the point of exporting a customisation if sync_on_migrate is not set?

Sync on install, but never again. It's useful in a lot of cases too.

On install of the app? So any additions in later versions are ignored.

from frappe.

Yeah.

from frappe.

Prop setters now sync by default instead of overriding: #25918

IDK if anyone really wants to delete all current prop setter and sync from code 😅

from frappe.

Idk any good solution for custom docperms yet, maybe best to remove it from this feature. Removal of docperm might actually mean it needs to be removed while syncing, so there's no way to guess intent from current version of code alone.

from frappe.

@ankush
Here's a patch I wrote to fix the behaviour, might be useful:

# for ensuring customisations exist instead of sync_on_migrate
import frappe
import os
import json


def insert(dt, doc):
	doc["doctype"] = dt
	d = frappe.get_doc(doc)
	d.insert()

def execute():
	path = frappe.get_app_path("app", "module", "custom")
	customs = [os.path.join(path, f) for f in os.listdir(path) if os.path.isfile(os.path.join(path, f))]
	for custom in customs:
		with open(custom) as f:
			data = json.loads(f.read())
		for key, docs in data.items():
			if not isinstance(docs, list):
				continue
			for doc in docs:
				try:
					if key == "property_setters":
						insert("Property Setter", doc)
					if key == "custom_fields":
						insert("Custom Field", doc)
				except frappe.DuplicateEntryError:
					pass
	frappe.db.commit()

EDIT: needs to be a normal insert to create the db table!

from frappe.