Portal Menu does not display in sidebar on Web Forms about frappe HOT 1 OPEN

1. Summary

The bug prevents the Portal Menu from being displayed by default in web forms when the Show
Sidebar option is checked, despite no custom Website Sidebar being selected. This behavior
contradicts the expected default behavior seen in other areas, such as the profile area.

2. Description

Issue:

When accessing web forms for editing profiles or managing addresses, enabling the Show
Sidebar option without selecting a custom Website Sidebar leads to the Portal Menu not being
displayed. This inconsistency contrasts with the typical behavior observed in similar areas within
the application.

Impact:
This bug affects the user experience by omitting expected functionality and may cause
confusion among users who anticipate seeing the Portal Menu in the sidebar.

Software Version:
ERPNext: 15.x.x-develop
Frappe: 15.x.x-develop
Module: Web Forms
Component: Sidebar Display

4. Steps to Reproduce
Navigate to /app/web-form/edit-profile or /app/web-form/addresses.
Enable the Show Sidebar option without selecting a custom Website Sidebar.
Visit /update-profile or /address/list.
Observe that the Portal Menu is not displayed in the sidebar area.

Observed Result:
The Portal Menu is missing from the sidebar despite enabling the Show Sidebar option.

Expected Result:
The Portal Menu should be displayed by default in the sidebar when the Show Sidebar option is
enabled, even if no custom Website Sidebar is selected.

5. Diagnosis
Initial Investigation:
Confirmed that the issue occurs when the Show Sidebar option is checked without selecting a
custom Website Sidebar.

Root Cause Analysis:
The bug likely stems from the conditional check in the web_form.py file, where the presence of
the Website Sidebar value is verified before displaying the Portal Menu. This check may be
unnecessary and results in the Portal Menu not being shown when it should.

6. Solution
Changes Made:
FilePath:/home/erp_user/frappe-
bench_v15/apps/frappe/frappe/website/doctype/web_form/web_form.py

Line No.: 233
Modification:
Replaced the line:
if self.show_sidebar and self.website_sidebar:
context.sidebar_items = get_sidebar_items(self.website_sidebar)
**
context.sidebar_items = get_sidebar_items(self.website_sidebar) if self.show_sidebar else
None

Before:

After
**

from frappe.