Code Monkey home page Code Monkey logo

Comments (3)

agritheory avatar agritheory commented on June 27, 2024 2

This by design and is not a bug. Custom DocPerms represent the ERP Instance as-configured. DocPerms represents the permission of a doctype as designed. For example, in some organizations it may appropriate for a Stock User to submit a Stock Reconciliation, but in others only to create and edit it and require a Stock Manager to submit it.

Short answer is that unless you are the author of the doctype, don't edit the Doc Perms.

from frappe.

ankush avatar ankush commented on June 27, 2024 1

This effectively conveys that even if a single Custom DocPerm exists, new DocPerms are fully ignored. So no new DocPerms will be accomodated? (which is not a configuration addition but a design addition)

Yes. Whenever a user goes and sees role permission manager and moves on from that that's exactly what they want permissions to be. So changing it again in future from a code update can be surprising to existing users.

All apps should essentially provide some sane defaults and almost never touch it again, and if they do, they shouldn't expect it to sync... because every organization works differently and our idea of "purchase user" doesn't quite align with theirs.

from frappe.

marination avatar marination commented on June 27, 2024

@agritheory That makes sense when it comes to the same role. Custom DocPerms should be given preference if a DocPerm of the same role exists.
But as i highlighted in the description, does it make sense that role Purchase User's DocPerm is ignored because a Custom DocPerm for the role Accounts User on the same doctype exists ?
This effectively conveys that even if a single Custom DocPerm exists, new DocPerms are fully ignored. So no new DocPerms will be accomodated? (which is not a configuration addition but a design addition)

PS: I changed the label, I wouldn't call this a bug yet. I'm just confused because I saw some unexpected behaviour and want to be clear to maintain and design apps in the future

from frappe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.