Code Monkey home page Code Monkey logo

Comments (4)

ankush avatar ankush commented on September 24, 2024 1

@cgallay this is how it works. We can't invoke a document's permission hook which requires a single document for doing SQL queries. It will make things insanely slow.

You should rewrite same logic as perm query, that will handle get_list part.

Example:

"Event": "frappe.desk.doctype.event.event.get_permission_query_conditions",

def get_permission_query_conditions(user):
if not user:
user = frappe.session.user
return """(`tabEvent`.`event_type`='Public' or `tabEvent`.`owner`={user})""".format(
user=frappe.db.escape(user),
)
def has_permission(doc, user):
if doc.event_type == "Public" or doc.owner == user:
return True
return False

from frappe.

ankush avatar ankush commented on September 24, 2024 1

has_permission is documented in hooks:

https://frappeframework.com/docs/user/en/python-api/hooks#document-permissions

perm query is documented on same page: https://frappeframework.com/docs/user/en/python-api/hooks#modify-list-query

from frappe.

cgallay avatar cgallay commented on September 24, 2024 1

Perfect, thanks! I was checking at the wrong location (https://docs.erpnext.com/docs/user/manual/en/user-permissions)

from frappe.

cgallay avatar cgallay commented on September 24, 2024

Thanks @ankush for the reply. I'll have to overwrite the get_permission_query_condition function then.

Would be nice if the documentation about permission gets an update. There is nothing mentioning the has_permission either.

from frappe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.