NPE on Cookie.name() about persistentcookiejar HOT 3 CLOSED

The problem here is that the cookies returned shouldn't be null, so making the null check would be a workaround but will not solve the problem. I will try to reproduce the issue and see why the null cookies are appearing, if you have any fixed steps to reproduce the issue it will be appreciated.

from persistentcookiejar.

I can reproduce the error though it's a very edge case.
The problem was because I was using the previous version of the library w/ okhttp2 which serialized SerializedHttpCookie under the old class.
When upgrading to okhttp3 with this library, since I'm using the same SharedPreference, it's still taking the byte data of the old Cookie and tried to serialize it to the new SerializableCookie.
It throws ClassNotFoundException and returns null during SerializableCookie.decode()

This error might also happen if someone use the same SharedPreference for their cookie and data.

IMO, null check is still required since the code SerializableCookie.decode might return null.
Either that, or throw a RuntimeException which clearly indicates why the deserialization has failed.

from persistentcookiejar.

Null check merged, thanks for your contribution

from persistentcookiejar.