problem for SharedPrefsCookiePersistor#saveAll about persistentcookiejar HOT 3 CLOSED

I may be mistaken, but as I was reading the code for the class

public class SharedPrefsCookiePersistor implements CookiePersistor {
    [ ... ]
    @Override
    public void saveAll(Collection<Cookie> cookies) {
        SharedPreferences.Editor editor = sharedPreferences.edit();
        for (Cookie cookie : cookies) {
            if (cookie.persistent()) {
                editor.putString(createCookieKey(cookie), new SerializableCookie().encode(cookie));
            }
        }
        editor.apply();
    }
   [ ... ]
}

The following piece of code seems weird:

if (cookie.persistent()) {
     editor.putString(createCookieKey(cookie), new SerializableCookie().encode(cookie));
}

As shown here

public boolean persistent()
Returns true if this cookie expires at the end of the current session.

The method 'Cookie.persistent()' returns true when it expires at the end of the current session... So shouldn't it be stored when this flag returns false?

I may be mistaken, but I think the issue is the misleading method which seems to do the opposite as you would expect.

from persistentcookiejar.

For now I haven't been able to reproduce any problems with the expiry dates. Also I think that there is an error in the OkHttp Javadoc:

Check this line comment.

private final boolean persistent; // True if 'expires' or 'max-age' is present.

Looking at how the variable is assigned when parsing the cookie seems that the behavior of the persistent flag is the opposite to the one indicated in the javadoc.

from persistentcookiejar.

Thank you for your reply! !

I rewrote saveAll method, do not check the persistent.(The problem may be the server.) Operating normally.

Thanks!!

from persistentcookiejar.