Code Monkey home page Code Monkey logo

Comments (5)

frankpf avatar frankpf commented on July 30, 2024

Everything fixed, except the background: none. I did leave it there to remember people they can change it directly on the html instead of adding a wrapper (even though I added a link, I think many won't check it and will still use an wrapper). Do you think I should add a comment explaining this?

from gridless-boilerplate.

necolas avatar necolas commented on July 30, 2024

Yeah, I think removing the unnecessary CSS and including a comment about adding backgrounds to html would be a good idea.

from gridless-boilerplate.

frankpf avatar frankpf commented on July 30, 2024

Done!

from gridless-boilerplate.

necolas avatar necolas commented on July 30, 2024

Noticed you're missing the zeroing out of margins on fieldset, and the inclusion of border:0 on legend to make it inherit color in IE

from gridless-boilerplate.

frankpf avatar frankpf commented on July 30, 2024

Fieldset margins are already 'fixed' in this rule:

p, blockquote, q, pre, address, hr, code, samp, dl, ol, ul, form, table, fieldset, menu, h4, h5, h6, img, figure, figcaption, button, hr {
    margin: 0 0 1.625em;
}

border:0 on legend was fixed.

Thank you!

from gridless-boilerplate.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.