Comments (5)
Everything fixed, except the background: none
. I did leave it there to remember people they can change it directly on the html instead of adding a wrapper (even though I added a link, I think many won't check it and will still use an wrapper). Do you think I should add a comment explaining this?
from gridless-boilerplate.
Yeah, I think removing the unnecessary CSS and including a comment about adding backgrounds to html
would be a good idea.
from gridless-boilerplate.
Done!
from gridless-boilerplate.
Noticed you're missing the zeroing out of margins on fieldset
, and the inclusion of border:0
on legend
to make it inherit color
in IE
from gridless-boilerplate.
Fieldset margins are already 'fixed' in this rule:
p, blockquote, q, pre, address, hr, code, samp, dl, ol, ul, form, table, fieldset, menu, h4, h5, h6, img, figure, figcaption, button, hr {
margin: 0 0 1.625em;
}
border:0
on legend was fixed.
Thank you!
from gridless-boilerplate.
Related Issues (15)
- line-height for input element HOT 1
- Launch 2.0
- Underscore on Line #246 HOT 2
- Documentation Link not working HOT 3
- dialog element should be removed
- default img margin
- Line Height of H3 element
- Demo Not Working
- README issues HOT 3
- index.html issues HOT 1
- Navigation menu is hidding HOT 2
- Inputs in IE8 HOT 1
- Highlight differences between gridless and normalize.css HOT 1
- Font-sizing formula HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gridless-boilerplate.