Code Monkey home page Code Monkey logo

Comments (2)

GoogleCodeExporter avatar GoogleCodeExporter commented on May 11, 2024
EXPECT_EQ(NULL, baz.foo()) is supposed to work.  Which platform/compiler are 
you using?

Thanks again for your contribution.  The next time could you discuss the plan on
[email protected] first?  The reason is to make sure you 
don't end
up wasting your time.

In this particular case, we had a discussion before and decided not to implement
ASSERT_NULL and ASSERT_NOT_NULL, as there are already options that don't involve
introducing new macros:

  ASSERT_EQ(NULL, foo);
  ASSERT_TRUE(foo != NULL);
  ASSERT_THAT(foo, NotNull());
etc.

The last one depends on our mocking framework, which will be open-sourced soon. 
 Thanks.

Original comment by [email protected] on 8 Oct 2008 at 9:32

  • Changed state: WontFix
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

from googletest.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 11, 2024
In the end, it wasn't a waste of my time -- it's something that we're going to 
end up
using. We'll end up pulling it into an extra header that we use, instead of in
gtest/gtest.h, but ASSERT_NULL and ASSERT_NOT_NULL seemed better for us. Plus, I
wasn't trying to do NULL, but 0 (e.g., ASSERT_NE(0, baz.foo())) since the C++ 
spec
indicates that NULL as (void*)0 (the C definition) isn't correct.

I encountered this problem with VS2005.

Original comment by [email protected] on 8 Oct 2008 at 9:57

from googletest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.