Code Monkey home page Code Monkey logo

Comments (4)

franckverrot avatar franckverrot commented on May 30, 2024 2

Implemented in https://github.com/franckverrot/terraform-provider-stripe/releases/tag/v1.7.0

Thanks @trea and thanks @ukd1 for reporting!

from terraform-provider-stripe.

ukd1 avatar ukd1 commented on May 30, 2024

Digging a little, it appears to be as on https://github.com/franckverrot/terraform-provider-stripe/blob/master/stripe/resource_stripe_plan.go#L188 getOk is used and returns false if something is zero -

terraform-provider-stripe/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go

Line 88 in 9996396

// GetOk returns the data for the given key and whether or not the key
specifically on

terraform-provider-stripe/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go

Line 102 in 9996396

exists = !eq.Equal(zero)

Seems like ValueOrZero might be useful; but not sure what the side effects are when it's supposed to be nil...

from terraform-provider-stripe.

franckverrot avatar franckverrot commented on May 30, 2024

Hey there, thanks for reporting this.

Do you wanna give a try sending a PR or would you like me to investigate (not sure I'll have time this week though so you can go ahead and try if you'd like to speed things up.) Thanks!

from terraform-provider-stripe.

ukd1 avatar ukd1 commented on May 30, 2024

@franckverrot we may have time to do a PR in a couple of weeks time - this is being put as an optional part of some internal work we're doing! If we start the work, I'll make sure we check here / comment here that we are doing so!

from terraform-provider-stripe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.