Code Monkey home page Code Monkey logo

Comments (5)

simonw avatar simonw commented on July 3, 2024 2

It wasn't instantly obvious to me that the file served by https://aviary.sh/install is the same as the file in https://github.com/team-video/aviary.sh/blob/master/install

Admittedly, I didn't spend a great deal of time thinking about this. I pasted https://aviary.sh/install into my browser, got a "download this file?" prompt, ran curl 'https://aviary.sh/install' to view it instead and filed an issue complaining about the mild inconvenience caused by the unexpected content-type header.

from aviary.sh.

dchester avatar dchester commented on July 3, 2024 1

Yes, makes sense. Let's move this to a place where we can set our own Content-Type headers.

from aviary.sh.

ldavison avatar ldavison commented on July 3, 2024

You might consider running something like this instead to inspect it: curl https://aviary.sh/install | vim - (you don't even have to pipe it to see the output).

FWIW, inspecting scripts like this in your browser vs via curl could produce different results. If the site is acting in a malicious manner the response could be modified when the user agent is curl.

from aviary.sh.

simonw avatar simonw commented on July 3, 2024

I can't pipe to vim on my phone. I just want a quick way of inspecting the script.

(Yeah the whole pipe to sudo pattern is pretty dubious from a security point of view, but I see that as a separate issue)

from aviary.sh.

dougbrunton avatar dougbrunton commented on July 3, 2024

We chatted about the | sudo bit before we released this, and it's not a pattern I use (I'll download a script, read it, and browse the sources of a project, especially for something that's running on infrastructure).

I like the intent behind the content type change, but shouldn't folks who use this come on over to the github repo and read the few lines of sources if they are going to use it on their machines?

Is getting to https://github.com/team-video/aviary.sh/blob/master/install too inconvenient from mobile?

from aviary.sh.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.